-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test suite for patching completeness #369
Conversation
joostinyi
commented
Jun 15, 2023
- Adds integration test suite for draft model patching completeness, marked as skip while implementation is worked on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with merging this, as is, but we should also add these a unit test level to make it easier to verify.
Maybe we can keep the unit tests for when you're adding the support for each.
@bolasim added integration test profiling in |
That's great. Thanks for doing that. We'll continue to optimize, I'm sure. |