Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test suite for patching completeness #369

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Conversation

joostinyi
Copy link
Collaborator

  • Adds integration test suite for draft model patching completeness, marked as skip while implementation is worked on.

@joostinyi joostinyi requested review from bolasim and aspctu June 15, 2023 22:50
Copy link
Collaborator

@bolasim bolasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merging this, as is, but we should also add these a unit test level to make it easier to verify.

Maybe we can keep the unit tests for when you're adding the support for each.

truss/tests/test_control_truss_patching.py Outdated Show resolved Hide resolved
truss/tests/test_control_truss_patching.py Show resolved Hide resolved
truss/tests/test_control_truss_patching.py Outdated Show resolved Hide resolved
truss/tests/test_control_truss_patching.py Outdated Show resolved Hide resolved
truss/tests/test_control_truss_patching.py Show resolved Hide resolved
@joostinyi
Copy link
Collaborator Author

@bolasim added integration test profiling in .test_durations to allow for better test chunking via pytest-split. it's not perfect – one failure mode I see is splitting tests that use the same docker image in different groups, meaning we need to pull the same image twice on each of the runners.

@joostinyi joostinyi merged commit b18abde into main Jun 16, 2023
8 checks passed
@joostinyi joostinyi deleted the justin/draft-test-suite branch June 16, 2023 23:48
@bolasim
Copy link
Collaborator

bolasim commented Jun 17, 2023

@bolasim added integration test profiling in .test_durations to allow for better test chunking via pytest-split. it's not perfect – one failure mode I see is splitting tests that use the same docker image in different groups, meaning we need to pull the same image twice on each of the runners.

That's great. Thanks for doing that. We'll continue to optimize, I'm sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants