Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase version requirements #733

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

squidarth
Copy link
Collaborator

@squidarth squidarth commented Nov 14, 2023

Summary

Make a few updates to Truss dependencies here:

  • Increase cython version (this was a blocker for some of the TTS work that @het was working on.
  • Increase FastAPI & Uvicorn versions. This version change allows us to finally get onto Pydantic 2 (which will help make truss installation easier for users with pydantic 2 installed, who currently cannot install truss).

None of these changes should have backwards incompatible changes, but I will test extensively before rolling this out.

Note that merging this should cause new images to get built, that match the tag

Testing

  1. Build a GPU image locally:
$ ./bin/generate_base_images.py --version-tag 0.7.16rc1 --python-version 3.10 --use-gpu y
 --job-type server --push

With this image, then make a separate branch, and bump the util.py file (see main...sshnaker/bump-requirements-on-truss-teset) to match the tag in the generate command.

Run context builder, and then test on dev.

I made a new model, and sent a bunch of requests to it (set concurrency to 10)

@squidarth squidarth requested review from bolasim, pankajroark and joostinyi and removed request for pankajroark November 15, 2023 01:54
@squidarth squidarth marked this pull request as ready for review November 15, 2023 01:54
@squidarth squidarth merged commit ddfd220 into main Nov 15, 2023
3 checks passed
@squidarth squidarth deleted the sshanker/bump-requirements-on-truss branch November 15, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants