Fix integration tests #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolasim
approved these changes
Feb 28, 2024
squidarth
approved these changes
Feb 28, 2024
bolasim
added a commit
that referenced
this pull request
Mar 6, 2024
* minor copy update (#838) * minor copy update * correct TensorFlow capitalization * Refactor `truss.server` out of templates to run as normal python program (#829) * [RFC][POC] Run truss server as normal python process * WIP: control server * Working draft server * Fix tests * WIP: continue fixing tests; issue with patch typing * Fix some mypy issues * Clean up some more imports * Move test files * Move some things around for readabliity * Cleanup everything except fs in tests * Only 4 tests left * Revert changes to test data * Fix all unit tests * Drop unnecessary config dump * Fix some integration tests; move packages dir * Clean up logging and patches * Fix packages path for TRT * Fix issue holding control server integration tests from passing * Fix rest of integration tests * Fix unit test and drop test_durations * Fix last integration test by passing APP_HOME and adding to path * Clean old templates, training code, deprecated serveres, and examples (#834) * [RFC][POC] Run truss server as normal python process * WIP: control server * Working draft server * Fix tests * WIP: continue fixing tests; issue with patch typing * Fix some mypy issues * Clean up some more imports * Move test files * Move some things around for readabliity * Cleanup everything except fs in tests * Only 4 tests left * Revert changes to test data * Fix all unit tests * Drop unnecessary config dump * Fix some integration tests; move packages dir * Clean up logging and patches * Fix packages path for TRT * Fix issue holding control server integration tests from passing * Fix rest of integration tests * Fix unit test and drop test_durations * Fix last integration test by passing APP_HOME and adding to path * Clean old templates, training code, deprecated serveres, and examples * reset vscode settings * Fix integration test using example * Improve `truss watch`: respect `.truss_ignore` when calculating patches (#812) Although we currently account for truss ignore patterns when detecting file changes with watchfiles.watch, we do not account for the ignore patterns when calculating patches or the truss hash and signature. This means that changes in ignored files will still be patched. This PR fixes that, along with some refactoring and bug fixes. * Fix integration tests (#843) * add pathspec to pyproject * poetry lock --no-update * fix calc_patch call * Fix os.PathLike type annotation This changes the `os.PathLike[Any]` annotation to `os.PathLike`. `os.PathLike` isn't subscriptable in Python 3.8, so `os.PathLike[Any]` results in `TypeError: 'ABCMeta' object is not subscriptable`. * Fall back to default .truss_ignore in truss upload If a user doesn't provide a .truss_ignore in their truss directory, fall back to the default .truss_ignore file specified in the truss package. * Move build configuration script to truss (#847) * Move build configuration script to truss * Update pyproject.toml * Move build configuration script to truss * Update pyproject.toml * Fix unintentially ignore build directory * Bump version to 0.10.0-rc.0 --------- Co-authored-by: Philip Kiely - Baseten <98474633+philipkiely-baseten@users.noreply.github.com> Co-authored-by: Bola Malek <bola@baseten.co> Co-authored-by: helenlyang <helen.yang@baseten.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 What
pyproject.tomlTrussHandle.calc_patchNote that this fixes most, but not all, of the integration tests (see run). Continuing to look into the RetryErrors.
馃捇 How
馃敩 Testing