Updating TRT-LLM template #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostinyi
approved these changes
Mar 28, 2024
truss/constants.py
Outdated
| @@ -98,7 +98,7 @@ | |||
|
|
|||
| REGISTRY_BUILD_SECRET_PREFIX = "DOCKER_REGISTRY_" | |||
|
|
|||
| TRTLLM_BASE_IMAGE = "baseten/trtllm-build-server:r23.12_baseten_v0.7.1_20240111" | |||
| TRTLLM_BASE_IMAGE = "baseten/trtllm-build-server:r23.12_baseten_v0.9.0_20240305" | |||
There was a problem hiding this comment.
can we condition this to use the build server or the lighter weight server image based on if the build occurs on baseten?
There was a problem hiding this comment.
leaving this to a followup as some investigation is needed as to why the generic builder doesn't actually work due to package issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 What
馃捇 How
馃敩 Testing