Add new docker auth settings to truss config. #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolasim
approved these changes
Mar 25, 2024
truss/truss_config.py
Outdated
| @@ -297,19 +297,67 @@ def to_list(self) -> List[Dict[str, str]]: | |||
| return [item.to_dict() for item in self.items] | |||
|
|
|||
|
|
|||
| class DockerAuthType(Enum): | |||
| GCS_SERVICE_ACCOUNT_JSON_BASE64 = "GCS_SERVICE_ACCOUNT_JSON_BASE64" | |||
| ACCESS_TOKEN = "ACCESS_TOKEN" | |||
There was a problem hiding this comment.
The access token is also technically, username:access_token | base64. If you're going to write the encoding in the name, maybe it's worth making that explicit here?
truss/truss_config.py
Outdated
|
|
||
| @dataclass | ||
| class DockerAuthSettings: | ||
| """ " |
bolasim
reviewed
Mar 25, 2024
@bolasim I'll add some docs after the backend changes go out |
bolasim
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/basetenlabs/baseten/pull/8198 for all of the context here, as well as for how I really tested.
馃殌 What
I would love feedback on the naming here / user interface. Currently, I've defined two auth methods:
Do these seem coherent?
馃捇 How
馃敩 Testing
Again, see https://github.com/basetenlabs/baseten/pull/8198 for the full, gory details.