Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass fastapi.HTTPExceptions through truss server. #886

Merged
merged 1 commit into from Apr 3, 2024

Conversation

marius-baseten
Copy link
Contributor

🚀 What

Add branch to truss server error handling that passes through fastapi.HTTPExceptions if raised in model code.

This allows to propagate more specific error messages/codes/details to the client.

💻 How

🔬 Testing

Copy link
Collaborator

@squidarth squidarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for writing the integration test here! I think this is fine, but I do want to flag what we discussed earlier (we shouldn't advertise this super widely so we have the flexibility to move off of fastapi if we need to)

@marius-baseten marius-baseten merged commit e7c260d into main Apr 3, 2024
10 checks passed
@marius-baseten marius-baseten deleted the marius/errors2 branch April 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants