Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use io.Reader/io.Writer interfaces to back the qoute database #5

Closed
Alextopher opened this issue Dec 15, 2023 · 0 comments · Fixed by #8
Closed

Use io.Reader/io.Writer interfaces to back the qoute database #5

Alextopher opened this issue Dec 15, 2023 · 0 comments · Fixed by #8
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Alextopher
Copy link
Collaborator

boyd_cooper/quotes.go

Line 10 in 38ac373

var quoteFile *os.File

In quotes.go the bot is using an *os.File to back the quotes database. It would be cleaner, and easier to test, if quotes were backed by generic io.Reader and io.Writer.
@Alextopher Alextopher added enhancement New feature or request good first issue Good for newcomers labels Dec 15, 2023
@Alextopher Alextopher mentioned this issue Dec 15, 2023
Closed
@Alextopher Alextopher linked a pull request Dec 21, 2023 that will close this issue
Implement io.Reader, io.Writer for quote database #8
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement io.Reader, io.Writer for quote database servusdei2018/boyd_cooper
1 participant
@Alextopher