Implement io.Reader, io.Writer for quote database #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
quoteFile
into anio.Reader
andio.Writer
interface at thequotes.go
level. Additionally, the logic intheory.go
was simplified to reduce allocations by eliminating the variablesentence
. A multi-stage Dockerfile was also introduced, resulting in a final stage image that is ~8% of its original size.Two notes regarding the Dockerfile:
gcr.io/distroless/static-debian12
should be switched togcr.io/distroless/base-debian12
so that the image includes the appropriate glibc shared objectsgo build
may be switched togo build -ldflags="-s -w"
in order to strip the DWARF tables and symbol table. This will result in a smaller binary at the cost of being able to debug the binary withgdb
ordelve