tests(quotes.go): create unit test #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alextopher
requested changes
Dec 23, 2023
| if quoteList[key] != val { | ||
| t.Errorf(`error, expected "%s", got "%s"`, val, quoteList[key]) | ||
| } | ||
| } |
There was a problem hiding this comment.
This test is a welcomed addition. My bigger concern is #7 with a few invariants I worry about.
- The "default" search always returns all quotes
- Searches return the expected quotes
- New quotes get added to the end of pre-existing searches
- There was a bug in a previous version that once a search ran until completion it would start returning
""instead of restarting. Exhausting a quote should just restart the search (with or without a new random order)
|
@servusdei2018 Are you planning on adding additional tests to this PR? I can merge this now without closing #7 |
|
Yeah I'll probably try to add some tests for searching in this PR too 👍🏽 |
|
Okay I now added test coverage for searches, and it should hit all the major points you listed:
|
|
This all looks good to me, I would say that the addition of tests has highlighted how much we depend on random globals all over the place and that should probably be looked at, though that can be its own PR for whoever feels so inclined. |
bashawhm
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
quotes.go. The loading and writing of quotes is tested to ensure expected functionality, by mocking an io.Reader and io.Writer.