[DO NOT MERGE] Show CI failure

[lucafavatella]

No description provided.

[lucafavatella]

Travis CI fails on branch develop (this PR has no changes from develop):

TASK [ansible-riak : install riak_shell.config with templated configuration] ***

fatal: [riak-test]: FAILED! => {"failed": true, "msg": "The conditional check 'riak_package == \"riak-ts\" and riak_shell_nodes is defined' failed. The error was: error while evaluating conditional (riak_package == \"riak-ts\" and riak_shell_nodes is defined): {{ riak_shell_nodes_list.split() }}: {% for host in groups[riak_shell_group] %}riak@{{ hostvars[host][riak_shell_interface]['ipv4']['address'] }} {% endfor %}: 'dict object' has no attribute u'riak'\n\nThe error appears to have been in '/home/travis/build/basho-labs/ansible-riak/tasks/main.yml': line 40, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: install riak_shell.config with templated configuration\n  ^ here\n"}

[lucafavatella]

I have same issue in my development and staging scripts :(

[lucafavatella]

It may be a minor syntax change in Ansible 2.2.2.0 as compared to 2.2.1.0.

[lucafavatella]

I need to understand where variable groups is bound.

UPDATE: https://docs.ansible.com/ansible/playbooks_variables.html#magic-variables-and-how-to-access-information-about-other-hosts

[lucafavatella]

I see the test places riak-test in /etc/ansible/hosts. And this bit did not change in the test recently.
I see the test does not override the default riak_shell_group: 'riak'. And this bit did not change in the test recently.

So I see two explanations:

• Ansible 2.2.2.0 changed from 2.2.1.0 the "short-circuitness" semantics of and; or
• Ansible 2.2.2.0 changed from 2.2.1.0 the behaviour when a dict is looked up by an inexistent key (as ingroups[riak_shell_group]) - at least in a for template loop.

[lucafavatella]

So I see two explanations:

Ansible 2.2.2.0 changed from 2.2.1.0 the "short-circuitness" semantics of and; or
Ansible 2.2.2.0 changed from 2.2.1.0 the behaviour when a dict is looked up by an inexistent key (as ingroups[riak_shell_group]) - at least in a for template loop.

Regardless of the explanation, I am attempting the following patch

 -riak_shell_nodes_list: "{% for host in groups[riak_shell_group] %}riak@{{ hostvars[host][riak_shell_interface]['ipv4']['address'] }} {% endfor %}"
 +riak_shell_nodes_list: "{% for host in groups[riak_shell_group]|default([]) %}riak@{{ hostvars[host][riak_shell_interface]['ipv4']['address'] }} {% endfor %}"

mainly based on https://stackoverflow.com/questions/28885184/default-value-for-dictionary-in-jinja2-ansible#28885760

[lucafavatella]

Looks working, preparing PR.

[lucafavatella]

PR #78 fixes this.