Fix progress check

[davidx]

This fixes a bug that slipped in:

• intent was to return if the build was in progress when receiving new comment. instead it returned also if it was completed. refactor in order for renaming methods around status. [completed, in_progress]
• fixes a state where the pr is closed but one wants to load a pullrequestworker instance (to look around)

[thumbot]

Thanks @davidx!

Settings

---
minimum_reviewers: 2
build_steps:
- bundle install
- bundle exec ruby test/test.rb
merge: true
org_mode: true
timeout: 1805
shell: "/bin/bash"
env:
  BUNDLE_GEMFILE: Gemfile

[thumbot]

fix_progress_check fc62479	➡️	master ac59094	⛔ completed

There seems to be an issue with build step **bundle_exec_ruby_test/test.rb** ! ☁️

✅ MERGE

Started at: 2016-12-01 10:34
Duration: 2 seconds.
Result: OK
Message: Merge Success: fix_progress_check fc62479 onto target branch: master ac59094
Exit Code: OK

📄

Updating ac59094..fc62479
Fast-forward (no commit created; -m option ignored)
 app.rb                            | 12 +++++++++++-
 lib/thumbs/pull_request_worker.rb |  5 ++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

---

✅ BUNDLE_INSTALL

Started at: 2016-12-01 10:34
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/master.ac59094.fix_progress_check.fc62479; bundle install

Using rake 11.3.0
Using concurrent-ruby 1.0.2
Using i18n 0.7.0
Using minitest 5.9.1
Using thread_safe 0.3.5
Using builder 3.2.2
Using erubis 2.7.0
Using mini_portile2 2.1.0
Using rack 2.0.1
Using public_suffix 2.0.4
Using mime-types-data 3.2016.0521
Using safe_yaml 1.0.4
Using diff-lcs 1.2.5
Using unf_ext 0.0.7.2
Using dust 0.1.6
Using excon 0.54.0
Using multipart-post 2.0.0
Using git 1.3.0
Using graphql 1.1.0
Using hashdiff 0.3.1
Using hijack 0.2.1
Using http-form_data 1.0.1
Using http_parser.rb 0.6.0
Using kgio 2.10.0
Using log4r 1.1.10
Using method_source 0.8.2
Using mustermann 1.0.0.beta2
Using netrc 0.11.0
Using power_assert 0.4.1
Using thor 0.19.4
Using raindrops 0.17.0
Using rspec-support 3.5.0
Using tilt 2.0.5
Using vcr 3.0.3
Using bundler 1.13.6
Using tzinfo 1.2.2
Using nokogiri 1.6.8.1
Using rack-test 0.6.3
Using rack-protection 2.0.0.beta2
Using addressable 2.5.0
Using mime-types 3.1
Using crack 0.4.3
Using unf 0.1.4
Using faraday 0.10.0
Using test-unit 3.2.3
Using unicorn 5.2.0
Using rspec-core 3.5.4
Using rspec-expectations 3.5.0
Using rspec-mocks 3.5.0
Using activesupport 5.0.0.1
Using loofah 2.0.3
Using xpath 2.0.0
Using sinatra 2.0.0.beta2
Using webmock 2.1.0
Using domain_name 0.5.20161129
Using sawyer 0.8.1
Using rails-dom-testing 2.0.1
Using graphql-client 0.2.3
Using rails-html-sanitizer 1.0.3
Using capybara 2.10.1
Using http-cookie 1.0.3
Using octokit 4.6.2
Using actionview 5.0.0.1
Using http 2.1.0
Using actionpack 5.0.0.1
Using railties 5.0.0.1
Using rspec-rails 3.5.2
Bundle complete! 22 Gemfile dependencies, 67 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

---

⛔ BUNDLE_EXEC_RUBY_TEST/TEST.RB

Started at: 2016-12-01 10:34
Duration: 263 seconds.
Result: ERROR
Message: Step bundle_exec_ruby_test/test.rb Failed!
Exit Code: 1

📄

cd /tmp/thumbs/master.ac59094.fix_progress_check.fc62479; bundle exec ruby test/test.rb

Loaded suite test/test
Started
.E
===============================================================================
Error: test_can_get_aggregate_build_status(Units::TestBuildSteps): RegexpError: empty char-class: /^feature_1474522484 [] \| :arrow_right: \| master 33fe0eb/
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:394:in `block in get_build_progress_comment'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:390:in `collect'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:390:in `get_build_progress_comment'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:441:in `clear_build_progress_comment'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_build_steps.rb:166:in `block (3 levels) in <top (required)>'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:44:in `block (7 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:43:in `block (6 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:42:in `block (5 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:41:in `block (4 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:40:in `block (3 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:39:in `block (2 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:38:in `block in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:37:in `default_vcr_state'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_build_steps.rb:159:in `block (2 levels) in <top (required)>'
/usr/local/lib/ruby/gems/2.3.0/gems/dust-0.1.6/lib/test_case_extension.rb:71:in `instance_eval'
/usr/local/lib/ruby/gems/2.3.0/gems/dust-0.1.6/lib/test_case_extension.rb:71:in `block in test'
===============================================================================
.................................F
===============================================================================
Failure: test_should_be_able_to_generate_base_and_sha_specific_build_guid(Units::TestCommon)
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_common.rb:6:in `block (3 levels) in <top (required)>'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:44:in `block (7 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:43:in `block (6 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:42:in `block (5 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:41:in `block (4 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:40:in `block (3 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:39:in `block (2 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:38:in `block in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:37:in `default_vcr_state'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_common.rb:4:in `block (2 levels) in <top (required)>'
/usr/local/lib/ruby/gems/2.3.0/gems/dust-0.1.6/lib/test_case_extension.rb:71:in `instance_eval'
/usr/local/lib/ruby/gems/2.3.0/gems/dust-0.1.6/lib/test_case_extension.rb:71:in `block in test'
<"master.33fe0eb.feature_1474522484.c42dcbf"> expected but was
<"master.33fe0eb.feature_1474522484.[]">

diff:
? master.33fe0eb.feature_1474522484.c42dcbf
?                                   []     
===============================================================================
.................F
===============================================================================
Failure: test_can_get_most_recent_sha(Units::TestState)
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_state.rb:20:in `block (3 levels) in <top (required)>'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:44:in `block (7 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:43:in `block (6 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:42:in `block (5 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:41:in `block (4 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:40:in `block (3 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:39:in `block (2 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:38:in `block in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:37:in `default_vcr_state'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_state.rb:19:in `block (2 levels) in <top (required)>'
/usr/local/lib/ruby/gems/2.3.0/gems/dust-0.1.6/lib/test_case_extension.rb:71:in `instance_eval'
/usr/local/lib/ruby/gems/2.3.0/gems/dust-0.1.6/lib/test_case_extension.rb:71:in `block in test'
<"c42dcbf4dc52bc581f946c70c5836b9889b74f9f"> expected but was
<[]>
===============================================================================
.......E
===============================================================================
Error: test_new_base_hook(WebhookTest): RegexpError: empty char-class: /^feature_1474522484 [] \| :arrow_right: \| master 33fe0eb/
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:394:in `block in get_build_progress_comment'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:390:in `collect'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:390:in `get_build_progress_comment'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:345:in `build_progress_status'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/lib/thumbs/pull_request_worker.rb:341:in `build_in_progress?'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/app.rb:179:in `block in <class:ThumbsWeb>'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1643:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1643:in `block in compile!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:989:in `block (3 levels) in route!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1008:in `route_eval'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:989:in `block (2 levels) in route!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1034:in `block in process_route'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1032:in `catch'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1032:in `process_route'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:987:in `block in route!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:986:in `each'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:986:in `route!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1111:in `block in dispatch!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1089:in `block in invoke'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1089:in `catch'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1089:in `invoke'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1108:in `dispatch!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:921:in `block in call!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1089:in `block in invoke'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1089:in `catch'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1089:in `invoke'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:921:in `call!'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:911:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-protection-2.0.0.beta2/lib/rack/protection/xss_header.rb:18:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-protection-2.0.0.beta2/lib/rack/protection/path_traversal.rb:16:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-protection-2.0.0.beta2/lib/rack/protection/json_csrf.rb:21:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-protection-2.0.0.beta2/lib/rack/protection/base.rb:50:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-protection-2.0.0.beta2/lib/rack/protection/base.rb:50:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-protection-2.0.0.beta2/lib/rack/protection/frame_options.rb:31:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-2.0.1/lib/rack/logger.rb:15:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-2.0.1/lib/rack/common_logger.rb:33:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:229:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:222:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-2.0.1/lib/rack/head.rb:12:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:192:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1965:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1516:in `block in call'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1737:in `synchronize'
/usr/local/lib/ruby/gems/2.3.0/gems/sinatra-2.0.0.beta2/lib/sinatra/base.rb:1516:in `call'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-test-0.6.3/lib/rack/mock_session.rb:30:in `request'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-test-0.6.3/lib/rack/test.rb:244:in `process_request'
/usr/local/lib/ruby/gems/2.3.0/gems/rack-test-0.6.3/lib/rack/test.rb:67:in `post'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_webhook.rb:71:in `block (6 levels) in test_new_base_hook'
     68:             cassette(:graphql, :record => :new_episodes) do
     69:               cassette(:graphql_more, :record => :new_episodes) do
     70: 
  => 71:                 post '/webhook', new_base_payload.to_json do
     72:                   assert last_response.body.include?("OK"), last_response.body
     73: 
     74:                 end
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_webhook.rb:69:in `block (5 levels) in test_new_base_hook'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_webhook.rb:68:in `block (4 levels) in test_new_base_hook'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_webhook.rb:67:in `block (3 levels) in test_new_base_hook'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_webhook.rb:65:in `block (2 levels) in test_new_base_hook'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_webhook.rb:64:in `block in test_new_base_hook'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:44:in `block (7 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:43:in `block (6 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:42:in `block (5 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:41:in `block (4 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:40:in `block (3 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:39:in `block (2 levels) in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:38:in `block in default_vcr_state'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr/util/variable_args_block_caller.rb:9:in `call_block'
/usr/local/lib/ruby/gems/2.3.0/gems/vcr-3.0.3/lib/vcr.rb:189:in `use_cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:34:in `cassette'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_helper.rb:37:in `default_vcr_state'
/tmp/thumbs/master.ac59094.fix_progress_check.fc62479/test/test_webhook.rb:47:in `test_new_base_hook'
===============================================================================
...

Finished in 246.979069671 seconds.
------
65 tests, 175 assertions, 2 failures, 2 errors, 0 pendings, 0 omissions, 0 notifications
93.8462% passed
------
0.26 tests/s, 0.71 assertions/s

---

⬜ 0 of 2 Code reviews from organization basho-labs

[thumbot]

fix_progress_check 8db688c	➡️	master ac59094	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2016-12-01 11:47
Duration: 0 seconds.
Result: OK
Message: Merge Success: fix_progress_check 8db688c onto target branch: master ac59094
Exit Code: OK

📄

Updating ac59094..8db688c
Fast-forward (no commit created; -m option ignored)
 app.rb                            | 12 +++++++++++-
 lib/thumbs/pull_request_worker.rb |  3 +++
 test/test_common.rb               |  2 +-
 test/test_helper.rb               |  4 ++--
 4 files changed, 17 insertions(+), 4 deletions(-)

---

✅ BUNDLE_INSTALL

Started at: 2016-12-01 11:47
Duration: 0 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/master.ac59094.fix_progress_check.8db688c; bundle install

Using rake 11.3.0
Using concurrent-ruby 1.0.2
Using i18n 0.7.0
Using minitest 5.9.1
Using thread_safe 0.3.5
Using builder 3.2.2
Using erubis 2.7.0
Using mini_portile2 2.1.0
Using rack 2.0.1
Using public_suffix 2.0.4
Using mime-types-data 3.2016.0521
Using safe_yaml 1.0.4
Using diff-lcs 1.2.5
Using unf_ext 0.0.7.2
Using dust 0.1.6
Using excon 0.54.0
Using multipart-post 2.0.0
Using git 1.3.0
Using graphql 1.1.0
Using hashdiff 0.3.1
Using hijack 0.2.1
Using http-form_data 1.0.1
Using http_parser.rb 0.6.0
Using kgio 2.10.0
Using log4r 1.1.10
Using method_source 0.8.2
Using mustermann 1.0.0.beta2
Using netrc 0.11.0
Using power_assert 0.4.1
Using thor 0.19.4
Using raindrops 0.17.0
Using rspec-support 3.5.0
Using tilt 2.0.5
Using vcr 3.0.3
Using bundler 1.13.6
Using tzinfo 1.2.2
Using nokogiri 1.6.8.1
Using rack-test 0.6.3
Using rack-protection 2.0.0.beta2
Using addressable 2.5.0
Using mime-types 3.1
Using crack 0.4.3
Using unf 0.1.4
Using faraday 0.10.0
Using test-unit 3.2.3
Using unicorn 5.2.0
Using rspec-core 3.5.4
Using rspec-expectations 3.5.0
Using rspec-mocks 3.5.0
Using activesupport 5.0.0.1
Using loofah 2.0.3
Using xpath 2.0.0
Using sinatra 2.0.0.beta2
Using webmock 2.1.0
Using domain_name 0.5.20161129
Using sawyer 0.8.1
Using rails-dom-testing 2.0.1
Using graphql-client 0.2.3
Using rails-html-sanitizer 1.0.3
Using capybara 2.10.1
Using http-cookie 1.0.3
Using octokit 4.6.2
Using actionview 5.0.0.1
Using http 2.1.0
Using actionpack 5.0.0.1
Using railties 5.0.0.1
Using rspec-rails 3.5.2
Bundle complete! 22 Gemfile dependencies, 67 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

---

✅ BUNDLE_EXEC_RUBY_TEST/TEST.RB

Started at: 2016-12-01 11:47
Duration: 59 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/master.ac59094.fix_progress_check.8db688c; bundle exec ruby test/test.rb

Loaded suite test/test
Started
.................................................................

Finished in 51.369237949 seconds.
------
65 tests, 177 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------
1.27 tests/s, 3.45 assertions/s

---

⬜ 0 of 2 Code reviews from organization basho-labs

[paegun]

+1