Skip to content

Commit

Permalink
Reduce log-level of more hintfile messages
Browse files Browse the repository at this point in the history
See previous commit for more detail.
  • Loading branch information
reiddraper committed Apr 16, 2014
1 parent 5ea929e commit 08c873c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/bitcask_fileops.erl
Expand Up @@ -336,8 +336,8 @@ fold_keys(#filestate{fd=Fd}=State, Fun, Acc, recovery, _, true) ->
Acc0;
{error, Reason} ->
HintFile = hintfile_name(State),
error_logger:error_msg("Hintfile '~s' failed fold: ~p\n",
[HintFile, Reason]),
error_logger:warning_msg("Hintfile '~s' failed fold: ~p\n",
[HintFile, Reason]),
fold_keys_loop(Fd, 0, Fun, Acc);
Acc1 ->
Acc1
Expand Down Expand Up @@ -590,9 +590,9 @@ fold_hintfile_loop(<<Tstamp:?TSTAMPFIELD, KeySz:?KEYSIZEFIELD,
fold_hintfile_loop(Rest, Fun, Acc,
Consumed, Args, EOI);
false ->
error_logger:error_msg("Hintfile '~s' contains pointer ~p ~p "
"that is greater than total data size ~p\n",
[HintFile, Offset, TotalSz, DataSize]),
error_logger:warning_msg("Hintfile '~s' contains pointer ~p ~p "
"that is greater than total data size ~p\n",
[HintFile, Offset, TotalSz, DataSize]),
{error, {trunc_hintfile, Acc0}}
end;
%% error case where we've gotten to the end of the file without the CRC match
Expand Down

16 comments on commit 08c873c

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from evanmcc
at 08c873c

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/bitcask/feature/invalid-hintfile-error-message-level = 08c873c into borshop-integration-164-feature/invalid-hintfile-error-message-level

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/bitcask/feature/invalid-hintfile-error-message-level = 08c873c merged ok, testing candidate = e378625

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanmcc
Copy link
Contributor

@evanmcc evanmcc commented on 08c873c Apr 16, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reiddraper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks. Retrying.

@reiddraper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop retry

@reiddraper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop: retry

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from evanmcc
at 08c873c

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/bitcask/feature/invalid-hintfile-error-message-level = 08c873c into borshop-integration-164-feature/invalid-hintfile-error-message-level

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/bitcask/feature/invalid-hintfile-error-message-level = 08c873c merged ok, testing candidate = 2a7e950

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge sha 2a7e950 is stale.

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/bitcask/feature/invalid-hintfile-error-message-level = 08c873c into borshop-integration-164-feature/invalid-hintfile-error-message-level

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/bitcask/feature/invalid-hintfile-error-message-level = 08c873c merged ok, testing candidate = 194208d

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding develop to borshop-integration-164-feature/invalid-hintfile-error-message-level = 194208d

Please sign in to comment.