Fix nif-mode and eunit_nif tests. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
evanmcc
commented
Jan 2, 2014
evanmcc
commented
- start with scott's commit 0d3acb0
- fix the issue introduced in 6c97173 more mininally
- ifdef out env reading even though it doesn't matter
- fix the issue introduced in 6c97173 more mininally - ifdef out env reading even though it doesn't matter
| application:set_env(bitcask, io_mode, Mode), | ||
| determine_file_module() | ||
| end. | ||
| -else. |
There was a problem hiding this comment.
This is OK. If the function ever gets more involve than this, it would be nice to only have the test bits ifdefed (for example, a function containing only the bits in _ clause).
|
The code looks good. eunit tests run in both modes from the makefile and starting and using Riak in both modes seems to work. I verified that by manually inserting/reading and peeking at the IO mode with bitcask_io:determine_file_module(). 👍 💃 ⛵ |
evanmcc
added a commit
that referenced
this pull request
Jan 3, 2014
Fix nif-mode and eunit_nif tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.