Skip to content

Commit

Permalink
Don't manually close PRs after merging
Browse files Browse the repository at this point in the history
Pair programmed with @Vagabond.

We tested this and github will automatically set the status of the
pull-request to closed/merged if the HEAD of the feature branch is
contained in the target branch. This happens when we fast-forward the
target branch to the merge-sha. And specifically, it looks at the target
branch, not whatever the default branch is set to in github
(master/develop).
  • Loading branch information
reiddraper authored and jaredmorrow committed Feb 28, 2014
1 parent a86e259 commit 0ed0fa8
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions bors.py
Expand Up @@ -516,11 +516,6 @@ def advance_target_ref_to_test(self):
self.dst().git().refs().heads(self.target_ref).patch(sha=self.merge_sha,
force=False)
self.add_comment(self.sha, s)
try:
self.dst().pulls(self.num).patch(state="closed")
self.closed = True
except github.ApiError:
self.log.info("closing failed; auto-closed after merge?")
try:
self.dst().git().refs().heads(self.test_ref).delete()
except github.ApiError:
Expand Down

0 comments on commit 0ed0fa8

Please sign in to comment.