-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: UTF-8 vs latin-1 regression #140
Conversation
Tried the following settings for platform_data_dir in riak 1.4.8
which parsed fine, but created the following directories:
which seems bad. as for vm.args,
and the node won't even start:
|
Looks like UTF-8 that are outside of latin-1 are supported in the erlang cookie, and I can join two nodes with the above cookie with no problem. |
Here's a list of characters that seem good for testing this:
|
In riak.conf ##
## Default: ./data
##
## Acceptable values:
## - the path to a directory
platform_data_dir = ./dataŒ {platform_data_dir,[46,47,100,97,116,97,338]},
[46,47,100,97,116,97,338,47,99,108,117,115,116,101,114,95,109,101,116,97,47,116,114,101,101,115] = "./dataŒ/cluster_meta/trees" |
distributed_cookie = riakŒ
|
so, as far as data dir goes, 1.4 creates the wrong name, but still starts. 2.0 creates the right name, but riak can't start. |
|
Eunit's failing on the builder, but passes locally. will investigate. |
All good now. didn't check in the test fixtures |
@@ -48,7 +48,15 @@ key <- head:word tail:("." word)* %{ | |||
%}; | |||
|
|||
%% A value is any character, with trailing whitespace stripped. | |||
value <- (!((ws* crlf) / comment) .)+ `unicode:characters_to_list(iolist_to_binary(Node))`; | |||
value <- (!((ws* crlf) / comment) .)+ %{ | |||
case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the weird line-wrapping and indentation here?
-- whitespace fixes in conf_parse.peg -- removed no longer applicable comment in favor of something more accurate -- added utf8 unit test to conf_parse.peg
👍 8ef24f7 |
Test: UTF-8 vs latin-1 regression Reviewed-by: seancribbs
@borshop merge |
We need to determine wether or not Riak 1.4's app.config and vm.args file could accept UTF-8 values or if they are restricted to latin-1. For example, multi backend bucket names.
If riak 1.4 can accept UTF-8 values, cuttlefish needs to be able to as well. If they can't , then it's desirable for cuttlefish to be able to detect non latin1 files and print an error message, but that might be a 2.0.1 fix.