BUG 1283: erlang_js uses non-thread-safe driver function #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
driver_output_term()
in an async worker pool threadis a big no-no. A solution is to use
driver_output_term()
in the
ready_async()
function, which executes in the properthread context.
Tested via:
beam/global.h:1345: Lock check assertion
errors.try to provoke a memory leak.
The following can be cut-and-paste'd into a Riak console/shell.
On my MBP, it runs for (very roughly) an hour. Perhaps it should
run even longer to try to find very small memory leaks?