Compile protobuf files with duplicate imports.

[UglyTroLL]

For example, a.proto imports 'b.proto' and 'c.proto' and b.proto imports 'c.proto' as well, which is a valid case. But when try to compile a.proto, the compiler will complain about something like '{32,erl_lint,{redefine_record,c}}' and '{26,erl_lint,{duplicated_export,{decode_c,1}}}' followed by compilation failure.

e.g.

• a.proto

import "b.proto";
import "c.proto";

message A {
  optional int32 aa = 1;
}

• b.proto

import "c.proto";

message B {
  optional int32 bb = 1;
}

• c.proto

message C {
  optional int32 cc = 1;
}

could not be compiled with error message:

=INFO REPORT==== 13-Aug-2014::18:16:02 ===
Writing header file to "a_pb.hrl"
** exception error: no match of right hand side value {error,[{"src/a_pb.erl",
                                                               [{32,erl_lint,{redefine_record,c}},
                                                                {32,erl_lint,{redefine_record,cc}},
                                                                {42,erl_lint,{redefine_function,{encode_c,1}}},
                                                                {42,erl_lint,{redefine_function,{encode_cc,1}}},
                                                                {110,erl_lint,{redefine_function,{decode_c,1}}},
                                                                {110,erl_lint,{redefine_function,{decode_cc,1}}},
                                                                {113,erl_lint,{redefine_function,{delimited_decode_c,1}}},
                                                                {113,erl_lint,
                                                                 {redefine_function,{delimited_decode_cc,1}}}]}],
                                                             [{"src/a_pb.erl",
                                                               [{26,erl_lint,{duplicated_export,{decode_c,1}}},
                                                                {26,erl_lint,{duplicated_export,{decode_cc,1}}},
                                                                {26,erl_lint,{duplicated_export,{delimited_decode_c,1}}},
                                                                {26,erl_lint,{duplicated_export,{delimited_decode_cc,1}}},
                                                                {26,erl_lint,{duplicated_export,{encode_c,1}}},
                                                                {26,erl_lint,{duplicated_export,{encode_cc,1}}}]}]}
     in function  protobuffs_compile:output/4 (src/protobuffs_compile.erl, line 155)

[UglyTroLL]

Any thoughts on this?

[lrascao]

i think the project is stagnant, no replies for some time now
you can look into another protobuf erlang implementation here on github:
gpb, much better code quality (no pikachus)

On Friday, August 15, 2014, UglyTroLL notifications@github.com wrote:

Any thoughts on this?

—
Reply to this email directly or view it on GitHub
#69 (comment)
.

[seancribbs]

We have intentionally left this repository at a stable spot. It does not implement all features, nor does it do all the implemented features correctly in all circumstances.

I (not speaking for Basho here) have intentions to do a rewrite, and a prototype is already underway, but it is not super-high on the priority list.

[lukebakken]

@UglyTroLL - I am reviewing PRs and issues in this repository. I can't accept this PR without a test case. Please provide one if you'd like to see this PR merged. Thanks! 😄

[UglyTroLL]

@lukebakken The unit test was added

[lukebakken]

FYI, this project (erlang_protobuffs) is no longer actively maintained. Please use gpb instead. gpb has erlang_protobuffs compatibility and is actively maintained by @tomas-abrahamsson