Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge 2.1 to master #24

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

merge 2.1 to master #24

wants to merge 7 commits into from

Conversation

JeetKunDoug
Copy link

Merge 2.1 to master, pulling forward the change to require syslog in app.src

@@ -7,7 +7,8 @@
{modules, []},
{applications, [
kernel,
stdlib
stdlib,
syslog

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erszcz
Copy link

erszcz commented Nov 21, 2016

Having syslog in .app.src is important for rebar3-built projects. Can we push this PR forward? Is it still in the queue due to some unwanted side-effects?

@michalwski
Copy link

@erszcz, looks like this is done in develop branch [1] or version 3.0.3 [2].

Is there any reason master branch is not actively developed but still default for this repo?

[1]. https://github.com/basho/lager_syslog/blob/develop/src/lager_syslog.app.src#L11
[2]. https://github.com/basho/lager_syslog/blob/3.0.3/src/lager_syslog.app.src#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants