Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using <atomic> , work on ARM64 CPU #235

Merged
merged 1 commit into from
Apr 19, 2022
Merged

using <atomic> , work on ARM64 CPU #235

merged 1 commit into from
Apr 19, 2022

Conversation

refactor
Copy link

for AtomicPointer:

  1. use , instead of ;
  2. make it work on ARM64 CPU

@seth-priya
Copy link

This works for ppc64le as well!

hmmr pushed a commit to TI-Tokyo/leveldb that referenced this pull request Oct 8, 2021
hmmr pushed a commit to TI-Tokyo/leveldb that referenced this pull request Nov 18, 2021
…moryBarrier

# Conflicts:
#	port/atomic_pointer.h
Copy link
Contributor

@matthewvon matthewvon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked up all the updated functions. Find nothing different from other examples on the Internet.

@aramallo
Copy link

Hi, +1 on this one, any reason why it has not been merged?

@martinsumner
Copy link
Contributor

Apologies for the delay, I didn't notice this at first ... and then it prompted some discussion within some of the bigger riak users.

All agreed now, thank-you for submitting, and thank-you to MVM for reviewing.

@martinsumner martinsumner merged commit bd45b8a into basho:develop-3.0 Apr 19, 2022
@martinsumner
Copy link
Contributor

Issue with ubuntu 14:

Submodule path 'leveldb_ee': checked out '1d13c28cb198770e03f805c7dd32d6a58260c1e2'
make[1]: Entering directory `/dbroot/riak/_build/default/lib/eleveldb/c_src/leveldb'
cc  -I /dbroot/riak/_build/default/lib/eleveldb/c_src/system/include -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -DSNAPPY  -DLEVELDB_VSN="2.0.37" -O2 -g -DNDEBUG     -fPIC -MM -E -MT port/port_posix.d -MT port/port_posix.o -MF port/port_posix.d port/port_posix.cc
cc  -I /dbroot/riak/_build/default/lib/eleveldb/c_src/system/include -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -DSNAPPY  -DLEVELDB_VSN="2.0.37" -O2 -g -DNDEBUG     -fPIC -MM -E -MT util/throttle.d -MT util/throttle.o -MF util/throttle.d util/throttle.cc
cc  -I /dbroot/riak/_build/default/lib/eleveldb/c_src/system/include -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -DSNAPPY  -DLEVELDB_VSN="2.0.37" -O2 -g -DNDEBUG     -fPIC -MM -E -MT util/thread_tasks.d -MT util/thread_tasks.o -MF util/thread_tasks.d util/thread_tasks.cc
In file included from /usr/include/c++/4.8/atomic:38:0,
                 from ./port/atomic_pointer.h:23,
                 from ./port/port_posix.h:51,
                 from port/port_posix.cc:5:
/usr/include/c++/4.8/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support is currently experimental, and must be enabled with the -std=c++11 or -std=gnu++11 compiler options.

Guessing for older versions of linux we might need some Makefile changes to set the -std=c++11 flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants