Stop applications nicely before killing extra processes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that applications get a chance to shut down themselves, before rebar will start killing their processes. This avoids ERROR REPORTS from application supervisors.
|
+1. @Tuncer? |
|
Thanks, merged. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
(also posted on the rebar mailing list)
I came across a situation where my eunit tests left a started
application and I got this:
=INFO REPORT==== 31-Oct-2011::23:15:24 ===
application: some_app_name
exited: killed
type: temporary
... and if I ran rebar with the -v flag also a number of "DEBUG: Kill"
printouts as well as a "Generic server... terminating" prinout.
Would it perhaps be better if rebar_eunit:reset_after_eunit/1 started
by shutting down applications, before moving on to killing processes?
I think so. Then the applications would get a chance to clean up
after themselves. The above prinout would change into this and -v
wouldn't show any extra kill messages:
=INFO REPORT==== 31-Oct-2011::23:11:33 ===
application: some_app_name
exited: stopped
type: temporary
BR,
Klas