rebar should expand VCS version in the top directory, if possible #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a VCS tag is present in the reltool.config file, rebar tries to expand it. However, it does so in the rel/ directory, which (at least for git) may not reveal the latest version. A problem is that if rebar was called with `cd rel; rebar generate`, rebar will not know what the top directory is. This can be solved by instead running `rebar generate skip_deps=true` from the top directory. This patch makes rebar_rel_utils use base_dir instead of the directory of reltool.config.
|
+1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a VCS tag is present in the reltool.config file, rebar tries
to expand it. However, it does so in the rel/ directory, which
(at least for git) may not reveal the latest version.
A problem is that if rebar was called with
cd rel; rebar generate,rebar will not know what the top directory is. This can be solved
by instead running
rebar generate skip_deps=truefrom the topdirectory. This patch makes rebar_rel_utils use base_dir instead
of the directory of reltool.config.