Add an atomic, bounded connection counter #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a potential fix to #45 (CLIENTS-368) (CLIENTS-745). A better solution would be to figure out how the client gets down to zero connections and tries to remove another one, but I wasn't able to trace that pathway as easily. |
This avoids a buffer underflow error I've seen in the client which caused the connectionCount to go from 0 to 65535
|
Hi Paul, Thanks for this. I'd like to get to the bottom of this as well. |
|
Hi @lukebakken, just for reference, there's an internal Basho issue that we've had open for a while with much more detailed logs which may be helpful to you as well. It's internal request #12852 in the helpdesk system. |
|
Thanks @pguelpa I've been participating internally on that ticket as well. |
This was referenced Feb 4, 2016
|
I've added your commits to #48. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a buffer underflow error I've seen in the client which caused the connectionCount to go from 0 to 65535