Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The RiakIndex annotation should not have a default value [JIRA: CLIENTS-559] #540

Closed
empovit opened this issue Aug 27, 2015 · 2 comments
Closed

The RiakIndex annotation should not have a default value [JIRA: CLIENTS-559] #540

empovit opened this issue Aug 27, 2015 · 2 comments
Assignees
@alexmoore
Labels
JIRA: Done

Comments

@empovit
Copy link
Contributor

empovit commented Aug 27, 2015

The RiakIndex annotation requires an index name to function properly, therefore it does not make sense for it to have a default value (especially if it is an empty string). Replacing

String name() default "";

with

String name();

will cause compilation errors whenever the annotation is used without an index name. The validation for empty string in AnnotationUtils should remain in place.
@Basho-JIRA Basho-JIRA changed the title The RiakIndex annotation should not have a default value The RiakIndex annotation should not have a default value [JIRA: CLIENTS-559] Aug 27, 2015
@empovit
Copy link
Contributor Author

empovit commented Aug 27, 2015

Submitted a pull request for this bug.

@alexmoore
Copy link
Contributor

Merged the PR into develop, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmoore alexmoore

Labels
JIRA: Done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexmoore @empovit @Basho-JIRA