Added getData() method to Basho\Riak\Search\Doc #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,13 +44,34 @@ public function __construct(\stdClass $data) | |||
| $this->data = $data; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns bucket location | |||
There was a problem hiding this comment.
It would actually be the location of an object not the bucket.
|
Looks good. Thanks @lastzero . |
christophermancini
added a commit
that referenced
this pull request
Feb 9, 2016
Added getData() method to Basho\Riak\Search\Doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Basho\Riak\Search\Doc does not allow to fetch all values returned by Solr #117 (CLIENTS-683) (CLIENTS-754)
Note that getData() returns an array (see issue comment). I also added tests and inline documentation.