missing riak_core modules on develop build

[jrwest]

trying to reproduce an issue on develop branch led to the following errors. need to investigate further but I don't have a moment right now so filing here for later.

$ for d in dev/dev{2,3,4,5}; do $d/bin/riak-admin cluster join dev1@127.0.0.1; done 
Success: staged join request for 'dev2@127.0.0.1' to 'dev1@127.0.0.1'
Success: staged join request for 'dev3@127.0.0.1' to 'dev1@127.0.0.1'
Success: staged join request for 'dev4@127.0.0.1' to 'dev1@127.0.0.1'
Success: staged join request for 'dev5@127.0.0.1' to 'dev1@127.0.0.1'
$ dev/dev1/bin/riak-admin cluster plan 
RPC to 'dev1@127.0.0.1' failed: {'EXIT',
                                 {undef,
                                  [{riak_core_console,print_staged,[],[]},
                                   {rpc,'-handle_call_call/6-fun-0-',5,
                                    [{file,"rpc.erl"},{line,205}]}]}}
$ dev/dev1/bin/riak-admin cluster commit 
RPC to 'dev1@127.0.0.1' failed: {'EXIT',
                                 {undef,
                                  [{riak_core_console,commit_staged,[],[]},
                                   {rpc,'-handle_call_call/6-fun-0-',5,
                                    [{file,"rpc.erl"},{line,205}]}]}}

[jrwest]

with make locked-deps ran before make devrel the build works fine. @jaredmorrow any off-the-top-of-your-head ideas before I dig a bit more?

[jaredmorrow]

Only thing I can think of is something getting left out of the toplevel reltool.config and modules aren't getting added to the rel as expected, but if core is doing the right thing, that shouldn't be a problem.

[kellymclaughlin]

I have reproduced the problem and it can be attributed to the merging of basho/node_package#155. There are several calls in riak_core_console that do not need to accept any input parameters, but accept just the empty list due to the exact limitation described in the node_package PR. I'll go through and convert all those console functions appropriately.

[jaredmorrow]

FYI, so this won't affect 2.0 right now, since that node_package PR wasn't included.

[jrwest]

agreed. on the riak-2.0.0rc1 tag I have confirmed that everything builds fine.

[kellymclaughlin]

After looking more into this and thinking about what it would take to make this work in mixed cluster scenarios up until the point where people are no longer upgrading to some future version from 2.0 (i.e. a few years down the road) I am not sure it is worth the effort. I think I will just open a PR to revert my node_package change and handle the no parameter rpc case for the specific scenrio in riak_cs I was working on the same way it is handled in riak-admin.

[kellymclaughlin]

basho/node_package#156