Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Ember.js. #37

Merged
merged 80 commits into from Aug 22, 2012
Merged

Convert to Ember.js. #37

merged 80 commits into from Aug 22, 2012

Conversation

cmeiklejohn
Copy link
Contributor

First, let me apologize for the massive size of this pull request. I explored breaking this apart into a bunch of smaller commits, but it was going to be too difficult as the introduction of the Ember router forced a bunch of changes across the entire application.

Outline of the changes in this pull request:

  • Add a set of rebar plugins to be used when compiling the application to concatenate JavaScript files and compile Handlebars templates.
  • Upgrade jQuery; add Ember.js, Handlebars and Minispade.
  • Deprecate pjax.
  • Introduce the router for routing page requests.
  • Convert the Ring and Snapshot pages over to Ember MVC.
  • Use legacy action pub/sub code to keep cluster page functioning for the time being as it's being deprecated.
  • Implement new webmachine modules for providing more RESTful resources which no longer return unnecessary data.
  • Use ember-data to load cluster and partition information, convert snapshot page to derive state of cluster rather than use an additional 3rd endpoint for this information.
  • Back button support, filters and pagination now have URL's /ring/filter/node/dev1@127.0.0.1/page/2, for instance.

Outstanding issues:

  • Sidebar is not properly collapsing, @jgnewman maybe you could take a look at this?

As we do not have automated tests for any of the visual states, we need to pretty extensively test this before merging.

@jgnewman

@travisbot
Copy link

This pull request passes (merged 64fdbc7 into aefaca5).

@travisbot
Copy link

This pull request passes (merged 6aff75b into aefaca5).

@travisbot
Copy link

This pull request passes (merged 480c26b into aefaca5).

@travisbot
Copy link

This pull request passes (merged 8f0483a into aefaca5).

@travisbot
Copy link

This pull request passes (merged b23872c into aefaca5).

@jgnewman
Copy link
Contributor

Ok, found one bug:

On the ring page, there is numbered pagination. Sometimes I have to click one of those numbers multiple times before it reacts to the click. The amount of times I have to click the number before it responds varies which leads me to believe it is somehow related to the ajax timer.

@travisbot
Copy link

This pull request passes (merged 8f268a5 into aefaca5).

@cmeiklejohn
Copy link
Contributor Author

@jgnewman Disabling the polling doesn't fix the problem -- I'm investigating further.

@travisbot
Copy link

This pull request passes (merged 76f113e into aefaca5).

@jgnewman
Copy link
Contributor

@cmeiklejohn Then you have my +1

@travisbot
Copy link

This pull request passes (merged 9b82417 into aefaca5).

@travisbot
Copy link

This pull request fails (merged dbb3172 into aefaca5).

@travisbot
Copy link

This pull request passes (merged dbb3172 into aefaca5).

@cmeiklejohn
Copy link
Contributor Author

@jgnewman Can I bug you for one more round of testing? I went through and reorganized the files better so we can keep better track of what we're going to be deprecating, and I also added a ton of jsdoc.

@travisbot
Copy link

This pull request passes (merged 079241c into aefaca5).

@cmeiklejohn
Copy link
Contributor Author

@jgnewman If it all looks good after your test, feel free to merge!

@jgnewman
Copy link
Contributor

+1

jgnewman added a commit that referenced this pull request Aug 22, 2012
@jgnewman jgnewman merged commit f7a330c into basho:master Aug 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants