-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Ember.js. #37
Conversation
Ok, found one bug: On the ring page, there is numbered pagination. Sometimes I have to click one of those numbers multiple times before it reacts to the click. The amount of times I have to click the number before it responds varies which leads me to believe it is somehow related to the ajax timer. |
@jgnewman Disabling the polling doesn't fix the problem -- I'm investigating further. |
@cmeiklejohn Then you have my +1 |
@jgnewman Can I bug you for one more round of testing? I went through and reorganized the files better so we can keep better track of what we're going to be deprecating, and I also added a ton of jsdoc. |
@jgnewman If it all looks good after your test, feel free to merge! |
+1 |
First, let me apologize for the massive size of this pull request. I explored breaking this apart into a bunch of smaller commits, but it was going to be too difficult as the introduction of the Ember router forced a bunch of changes across the entire application.
Outline of the changes in this pull request:
Outstanding issues:
As we do not have automated tests for any of the visual states, we need to pretty extensively test this before merging.
@jgnewman