-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow gen_nb_server to use IPv6 addresses. #249
Conversation
Err -> | ||
Err | ||
end; | ||
listen_on(CallbackModule, IpAddr, Port) when is_tuple(IpAddr) andalso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't there be a catchall case here for when none of the guarded versions are satisfied, throwing an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, adding.
+1 to merge, thanks! I used the diff below to verify that the HTTP listener, PB listener, and handoff listener are all using IPv6. Note that the distributed Erlang ports are still using IPv4.
Diff:
|
Allow gen_nb_server to use IPv6 addresses.
This supersedes #245, supporting both tuple and string-formatted addresses, and cleans up extraneous whitespace in the file.