dont start coverage timeout timer if timeout is infinite #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Change looks good, it fixes mapred_verify_rt and doesn't break verify_api_timeouts or verify_listkeys |
jrwest
added a commit
that referenced
this pull request
May 30, 2013
dont start coverage timeout timer if timeout is infinite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the timeout is
infinitythe coverage fsm crashes w/o this change. To verify runmapred_verify_rtwithriak_testw/ and w/o this change (or any mapreduce request that uses aninfinitytimeout, e.g. basho_bench)