update bad value protection for timer value #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,6 +197,10 @@ init({test, Args, StateProps}) -> | |||
| %% @private | |||
| maybe_start_timeout_timer(infinity) -> | |||
| ok; | |||
| maybe_start_timeout_timer(Bad) when not is_integer(Bad) -> | |||
| maybe_start_timeout_timer(?DEFAULT_TIMEOUT); | |||
| maybe_start_timeout_timer(undefined) -> | |||
There was a problem hiding this comment.
this clause is covered by the previous one
| @@ -97,6 +97,8 @@ behaviour_info(callbacks) -> | |||
| behaviour_info(_) -> | |||
| undefined. | |||
|
|
|||
| -define(DEFAULT_TIMEOUT, 60000*8). | |||
There was a problem hiding this comment.
what's the reasoning behind this default? is it just supposed to be greater than all the other timeouts in layers above?
There was a problem hiding this comment.
It's the same default that's defined in the client.
There was a problem hiding this comment.
ok cool. just wanted to know its origin. thanks
|
|
|
+1 |
evanmcc
added a commit
that referenced
this pull request
Jun 4, 2013
update bad value protection for timer value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are many paths to spawn a coverage FSM, it would be a lot of code duplication to validate the timeout at each of those entry points. Instead, expand may_start_timeout_timer to guard against more categories of bad input.
Fixes basho/riak_kv#571
cc @jrwest @seancribbs