Fix meck related unit test problems #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meck now needs a couple of flags in meck:new for some of our tests: * non_strict so we can create a fresh non-existent module * no_link so it doesn't link to the processes created with a meck * module. Bad when we kill things on purpose. Trying non_strict meck flag in riak_core_stat_cache. The build failed with an undefined_module error setting up this text. I can not get that to happen locally, but this flag has fixed similar problems in other tests.
|
Tests fail before. Tests pass after. +1 to merge. |
engelsanchez
added a commit
that referenced
this pull request
Sep 4, 2013
Fix meck related unit test problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meck now needs a couple of flags in meck:new for some of our tests: