Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_set_forwarding crashes [JIRA: RIAK-1459] #693

Merged
merged 1 commit into from Dec 31, 2014

Conversation

andrewjstone
Copy link
Contributor

handle modstate={deleted,_} in riak_kv_vnode:mod_set_forwarding/2

@andrewjstone andrewjstone changed the title handle modstate={deleted,_} in riak_kv_vnode:mod_set_forwarding/2 Fix for mod_set_forwarding crashes Dec 30, 2014
@andrewjstone
Copy link
Contributor Author

Fixes this crash:

exception exit: {{{badrecord,state},[{riak_kv_vnode,set_vnode_forwarding,2,[{file,"src/riak_kv_vnode.erl"},{line,1028}]},{riak_core_vnode,mod_set_forwarding,2,[{file,"src/riak_core_vnode.erl"},{line,1050}]},{riak_core_vnode,handle_event,3,[{file,"src/riak_core_vnode.erl"},{line,713}]},{gen_fsm,handle_msg,7,[{file,"gen_fsm.erl"},{line,505}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,239}]}]},[{gen_fsm,terminate,7,[{file,"gen_fsm.erl"},{line,622}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,239}]}]}

@russelldb
Copy link
Member

That was my bad. Sorry @andrewjstone. Good catch +1.

@russelldb
Copy link
Member

+1 80d9c1b

edit sdc: removed @borshop mention, not necessary

borshop added a commit that referenced this pull request Dec 31, 2014
Fix for mod_set_forwarding crashes

Reviewed-by: russelldb
@seancribbs
Copy link
Contributor

@borshop merge

@borshop borshop merged commit 80d9c1b into 2.0 Dec 31, 2014
@seancribbs seancribbs deleted the bugfix/vnode-modstate-deleted branch January 6, 2015 17:47
@Basho-JIRA Basho-JIRA changed the title Fix for mod_set_forwarding crashes mod_set_forwarding crashes [JIRA: RIAK-1459] Jan 6, 2015
@Basho-JIRA
Copy link

Adding to Jira to track bug found in testing 2.0.4 and with issue in GH.

_[posted via JIRA by Deb Rakow]_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants