Remove admin.secret from configuration

[kuenishi]

Instead it is retrieved from Riak directly in startup sequence, from
admin.key specified at configuration file. But in special case
admin.key is specified as "admin-key", it does not retrieve admin
secret from Riak, instead sets it as admin-secret. admin.secret will
be deprecated in near future, which is currently ignored at all.

[shino]

{error, {T,E}}? To satisfy return type of check_admin_creds

[kuenishi]

Updated ^^;

[shino]

Diff looks nice 👍

First run of r_t with mb flavor:

Test Results:
user_test-cs_multi_backend                  : pass
upgrade_downgrade_test-cs_multi_backend     : pass
too_large_entity_test-cs_multi_backend      : pass
storage_stats_test_2-cs_multi_backend       : pass
storage_stats_test-cs_multi_backend         : pass
storage_stats_detailed_test-cs_multi_backend: pass
stats_test-cs_multi_backend                 : pass
stanchion_switch_test-cs_multi_backend      : fail
sibling_benchmark-cs_multi_backend          : pass
select_gc_bucket_test-cs_multi_backend      : pass
riak_cs_debug_test-cs_multi_backend         : pass
repl_v3_test-cs_multi_backend               : pass
regression_tests_2-cs_multi_backend         : pass
regression_tests-cs_multi_backend           : pass
put_copy_test-cs_multi_backend              : pass
object_get_test-cs_multi_backend            : pass
object_get_conditional_test-cs_multi_backend: pass
mp_upload_test-cs_multi_backend             : pass
migration_mixed_test-cs_multi_backend       : fail
migration_15_to_20_test-cs_multi_backend    : fail
mb_trans_test-cs_multi_backend              : fail
mb_trans2_test-cs_multi_backend             : fail
mb_pg_test-cs_multi_backend                 : pass
mb_disjoint_test-cs_multi_backend           : pass
list_objects_v2_test-cs_multi_backend       : pass
list_objects_test-cs_multi_backend          : pass
legacy_s3_rewrite_test-cs_multi_backend     : pass
gc_tests-cs_multi_backend                   : pass
external_client_tests-cs_multi_backend      : pass
cs743_regression_test-cs_multi_backend      : pass
buckets_test-cs_multi_backend               : pass
block_audit_test-cs_multi_backend           : pass
auth_bypass_test-cs_multi_backend           : pass
active_delete_test-cs_multi_backend         : pass
access_stats_test-cs_multi_backend          : pass
---------------------------------------------
5 Tests Failed
30 Tests Passed

[kuenishi]

stanchion_switch_test passed for me in both mb and single SUPERcluster(tm).

[kuenishi]

My results:

Test Results:
user_test-cs_multi_backend                  : pass (  38.6 sec)
upgrade_downgrade_test-cs_multi_backend     : pass ( 167.8 sec)
too_large_entity_test-cs_multi_backend      : pass (  35.4 sec)
storage_stats_test_2-cs_multi_backend       : pass (  43.9 sec)
storage_stats_test-cs_multi_backend         : pass (  43.7 sec)
storage_stats_detailed_test-cs_multi_backend: pass (  59.3 sec)
stats_test-cs_multi_backend                 : pass (  36.4 sec)
stanchion_switch_test-cs_multi_backend      : pass (  40.1 sec)
sibling_benchmark-cs_multi_backend          : pass (  70.4 sec)
select_gc_bucket_test-cs_multi_backend      : pass (  65.1 sec)
riak_cs_debug_test-cs_multi_backend         : fail (  20.1 sec)
repl_v3_test-cs_multi_backend               : pass ( 204.9 sec)
regression_tests_2-cs_multi_backend         : pass (  91.3 sec)
regression_tests-cs_multi_backend           : pass (  35.6 sec)
put_copy_test-cs_multi_backend              : pass (  36.7 sec)
object_get_test-cs_multi_backend            : pass (  39.6 sec)
object_get_conditional_test-cs_multi_backend: pass (  31.3 sec)
mp_upload_test-cs_multi_backend             : pass (  43.7 sec)
migration_mixed_test-cs_multi_backend       : pass ( 265.4 sec)
migration_15_to_20_test-cs_multi_backend    : pass ( 249.2 sec)
mb_trans_test-cs_multi_backend              : fail ( 236.4 sec)
mb_trans2_test-cs_multi_backend             : fail ( 279.3 sec)
mb_pg_test-cs_multi_backend                 : pass ( 227.2 sec)
mb_disjoint_test-cs_multi_backend           : pass (  59.6 sec)
list_objects_v2_test-cs_multi_backend       : pass ( 370.3 sec)
list_objects_test-cs_multi_backend          : pass (  48.4 sec)
legacy_s3_rewrite_test-cs_multi_backend     : pass (  51.4 sec)
gc_tests-cs_multi_backend                   : pass ( 106.0 sec)
external_client_tests-cs_multi_backend      : pass ( 171.2 sec)
cs743_regression_test-cs_multi_backend      : pass (  55.1 sec)
buckets_test-cs_multi_backend               : pass (  37.2 sec)
block_audit_test-cs_multi_backend           : pass (  67.9 sec)
auth_bypass_test-cs_multi_backend           : pass (  35.2 sec)
active_delete_test-cs_multi_backend         : pass (  70.3 sec)
access_stats_test-cs_multi_backend          : pass (  57.1 sec)
---------------------------------------------
3 Tests Failed
32 Tests Passed
That's 91.42857142857143% for those keeping score

mb_trans_test is failing because rcs-dev2 node is not able to fetch admin key and secret from Riak (dev2 node). Is riak_host in riak.conf supposed to be the master supercluster member?

[shino]

Correct. In mb flavor, cs nodes except dev1 are not configured properly, became they are not used at all before.

[kuenishi]

Please review this. basho/riak_cs_multibag#33

[kuenishi]

migration_mixed_test-cs_multi_backend       : fail ( 181.9 sec)
migration_15_to_20_test-cs_multi_backend    : fail ( 353.8 sec)
mb_trans_test-cs_multi_backend              : pass ( 106.6 sec)
mb_trans2_test-cs_multi_backend             : fail ( 278.1 sec)

[shino]

xref basho/riak_cs_multibag#34

[shino]

All riak_test cases passed for both basic and mb flavors by the combination with basho/riak_cs_multibag#33.

Great for better security / less operational burden ❗

[shino]

@borshop merge

[TJC]

hey guys -- could you update http://docs.basho.com/riak/cs/2.1.1/cookbooks/configuration/riak-cs/ to reflect the current correct and best practices in regard to the admin secret? I'm confused.