Fix policy version validation in PUT Bucket Policy #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example in docs are already in 2012 while we still live in 2008. http://docs.aws.amazon.com/AmazonS3/latest/dev/example-bucket-policies.html |
CS 1.4 does not validate the version of policy json when the policy is being put, but validates when 'using' it (=anytime when you touch anything in that bucket). This commit adds validation in WM resource of PUT Bucket policy and related error codes. There might be invalid policy versions in already upload buckets, this commit also validates only version "2012-10-17" and "2008-10-17" which are also valid in S3. Other invalid version strings continue to be invalid. With existing buckets created at 1.3 and 1.4 with invalid version strings, any operations on that bucket or on objects in that bucket can't be touched and refused with 403. Tests and workaround to fixup those buckets will follow.
borshop
added a commit
that referenced
this pull request
Jul 15, 2014
Fix policy version validation in PUT Bucket Policy Reviewed-by: shino
|
@borshop merge |
|
Oops, the above mention from the issue 977 was wrong. Please ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS 1.4 does not validate the version of policy json when the policy
is being put, but validates when 'using' it (=anytime when you touch
anything in that bucket). This commit adds validation in WM resource
of PUT Bucket policy and related error codes.
There might be invalid policy versions in already upload buckets,
this commit also validates only version "2012-10-17" and "2008-10-17"
which are also valid in S3. Other invalid version strings continue
to be invalid. With existing buckets created at 1.3 and 1.4 with
invalid version strings, any operations on that bucket or on objects
in that bucket can't be touched and refused with 403.
Tests and workaround to fixup those buckets will follow.