Enable proxy_get in multibag #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shino
commented
Jun 17, 2015
shino
commented
- Cache cluster id for each bag in ETS table
- Add riak_test case to retrieve objects (normal upload, MP upload, copied and copied MP) through proxy_get
| mb(MegaBytes) -> | ||
| MegaBytes * 1024 * 1024. | ||
|
|
||
| assert_whole_content(UserConfig, Bucket, Key, ExpectedContent) -> |
There was a problem hiding this comment.
I believe this function is general enough and worth moving out to rtcs.erl.
|
Basic design looks as a whole good to me. |
- Delete trailing white spaces - Delete useless comments - Use utility functions of rtcs_object module
|
This pull request can't be bad, +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.