-
Notifications
You must be signed in to change notification settings - Fork 233
/
riak_kv_get_fsm.erl
536 lines (468 loc) · 20.8 KB
/
riak_kv_get_fsm.erl
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
%% -------------------------------------------------------------------
%%
%% riak_get_fsm: coordination of Riak GET requests
%%
%% Copyright (c) 2007-2010 Basho Technologies, Inc. All Rights Reserved.
%%
%% This file is provided to you under the Apache License,
%% Version 2.0 (the "License"); you may not use this file
%% except in compliance with the License. You may obtain
%% a copy of the License at
%%
%% http://www.apache.org/licenses/LICENSE-2.0
%%
%% Unless required by applicable law or agreed to in writing,
%% software distributed under the License is distributed on an
%% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
%% KIND, either express or implied. See the License for the
%% specific language governing permissions and limitations
%% under the License.
%%
%% -------------------------------------------------------------------
-module(riak_kv_get_fsm).
-behaviour(gen_fsm).
-include_lib("riak_kv_vnode.hrl").
-ifdef(TEST).
-include_lib("eunit/include/eunit.hrl").
-export([test_link/7, test_link/5]).
-endif.
-export([start/6, start_link/6, start_link/4]).
-export([init/1, handle_event/3, handle_sync_event/4,
handle_info/3, terminate/3, code_change/4]).
-export([prepare/2,validate/2,execute/2,waiting_vnode_r/2,waiting_read_repair/2]).
-type detail() :: timing |
vnodes.
-type details() :: [detail()].
-type option() :: {r, pos_integer()} | %% Minimum number of successful responses
{pr, non_neg_integer()} | %% Minimum number of primary vnodes participating
{basic_quorum, boolean()} | %% Whether to use basic quorum (return early
%% in some failure cases.
{notfound_ok, boolean()} | %% Count notfound reponses as successful.
{timeout, pos_integer() | infinity} | %% Timeout for vnode responses
{details, details()} | %% Return extra details as a 3rd element
{details, true} |
details.
-type options() :: [option()].
-type req_id() :: non_neg_integer().
-export_type([options/0, option/0]).
-record(state, {from :: {raw, req_id(), pid()},
options=[] :: options(),
n :: pos_integer(),
preflist2 :: riak_core_apl:preflist2(),
req_id :: non_neg_integer(),
starttime :: pos_integer(),
get_core :: riak_kv_get_core:getcore(),
timeout :: infinity | pos_integer(),
tref :: reference(),
bkey :: {riak_object:bucket(), riak_object:key()},
bucket_props,
startnow :: {non_neg_integer(), non_neg_integer(), non_neg_integer()},
get_usecs :: non_neg_integer()
}).
-define(DEFAULT_TIMEOUT, 60000).
-define(DEFAULT_R, default).
-define(DEFAULT_PR, 0).
%% ===================================================================
%% Public API
%% ===================================================================
%% In place only for backwards compatibility
start(ReqId,Bucket,Key,R,Timeout,From) ->
start_link({raw, ReqId, From}, Bucket, Key, [{r, R}, {timeout, Timeout}]).
start_link(ReqId,Bucket,Key,R,Timeout,From) ->
start_link({raw, ReqId, From}, Bucket, Key, [{r, R}, {timeout, Timeout}]).
%% @doc Start the get FSM - retrieve Bucket/Key with the options provided
%%
%% {r, pos_integer()} - Minimum number of successful responses
%% {pr, non_neg_integer()} - Minimum number of primary vnodes participating
%% {basic_quorum, boolean()} - Whether to use basic quorum (return early
%% in some failure cases.
%% {notfound_ok, boolean()} - Count notfound reponses as successful.
%% {timeout, pos_integer() | infinity} - Timeout for vnode responses
-spec start_link({raw, req_id(), pid()}, binary(), binary(), options()) ->
{ok, pid()} | {error, any()}.
start_link(From, Bucket, Key, GetOptions) ->
gen_fsm:start_link(?MODULE, [From, Bucket, Key, GetOptions], []).
%% ===================================================================
%% Test API
%% ===================================================================
-ifdef(TEST).
%% Create a get FSM for testing. StateProps must include
%% starttime - start time in gregorian seconds
%% n - N-value for request (is grabbed from bucket props in prepare)
%% bucket_props - bucket properties
%% preflist2 - [{{Idx,Node},primary|fallback}] preference list
%%
test_link(ReqId,Bucket,Key,R,Timeout,From,StateProps) ->
test_link({raw, ReqId, From}, Bucket, Key, [{r, R}, {timeout, Timeout}], StateProps).
test_link(From, Bucket, Key, GetOptions, StateProps) ->
gen_fsm:start_link(?MODULE, {test, [From, Bucket, Key, GetOptions], StateProps}, []).
-endif.
%% ====================================================================
%% gen_fsm callbacks
%% ====================================================================
%% @private
init([From, Bucket, Key, Options]) ->
StartNow = now(),
StateData = #state{from = From,
options = Options,
bkey = {Bucket, Key},
startnow = StartNow},
{ok, prepare, StateData, 0};
init({test, Args, StateProps}) ->
%% Call normal init
{ok, prepare, StateData, 0} = init(Args),
%% Then tweak the state record with entries provided by StateProps
Fields = record_info(fields, state),
FieldPos = lists:zip(Fields, lists:seq(2, length(Fields)+1)),
F = fun({Field, Value}, State0) ->
Pos = proplists:get_value(Field, FieldPos),
setelement(Pos, State0, Value)
end,
TestStateData = lists:foldl(F, StateData, StateProps),
%% Enter into the execute state, skipping any code that relies on the
%% state of the rest of the system
{ok, validate, TestStateData, 0}.
%% @private
prepare(timeout, StateData=#state{bkey=BKey={Bucket,_Key}}) ->
{ok, Ring} = riak_core_ring_manager:get_my_ring(),
BucketProps = riak_core_bucket:get_bucket(Bucket, Ring),
DocIdx = riak_core_util:chash_key(BKey),
N = proplists:get_value(n_val,BucketProps),
UpNodes = riak_core_node_watcher:nodes(riak_kv),
Preflist2 = riak_core_apl:get_apl_ann(DocIdx, N, Ring, UpNodes),
{next_state, validate, StateData#state{starttime=riak_core_util:moment(),
n = N,
bucket_props=BucketProps,
preflist2 = Preflist2}, 0}.
%% @private
validate(timeout, StateData=#state{from = {raw, ReqId, _Pid}, options = Options,
n = N, bucket_props = BucketProps, preflist2 = PL2}) ->
Timeout = get_option(timeout, Options, ?DEFAULT_TIMEOUT),
R0 = get_option(r, Options, ?DEFAULT_R),
PR0 = get_option(pr, Options, ?DEFAULT_PR),
R = riak_kv_util:expand_rw_value(r, R0, BucketProps, N),
PR = riak_kv_util:expand_rw_value(pr, PR0, BucketProps, N),
NumVnodes = length(PL2),
NumPrimaries = length([x || {_,primary} <- PL2]),
if
R =:= error ->
client_reply({error, {r_val_violation, R0}}, StateData),
{stop, normal, StateData};
R > N ->
client_reply({error, {n_val_violation, N}}, StateData),
{stop, normal, StateData};
PR =:= error ->
client_reply({error, {pr_val_violation, PR0}}, StateData),
{stop, normal, StateData};
PR > N ->
client_reply({error, {n_val_violation, N}}, StateData),
{stop, normal, StateData};
PR > NumPrimaries ->
client_reply({error, {pr_val_unsatisfied, PR, NumPrimaries}}, StateData),
{stop, normal, StateData};
R > NumVnodes ->
client_reply({error, {insufficient_vnodes, NumVnodes, need, R}}, StateData),
{stop, normal, StateData};
true ->
BQ0 = get_option(basic_quorum, Options, default),
FailThreshold =
case riak_kv_util:expand_value(basic_quorum, BQ0, BucketProps) of
true ->
erlang:min((N div 2)+1, % basic quorum, or
(N-R+1)); % cannot ever get R 'ok' replies
_ElseFalse ->
N - R + 1 % cannot ever get R 'ok' replies
end,
AllowMult = proplists:get_value(allow_mult,BucketProps),
NFOk0 = get_option(notfound_ok, Options, default),
NotFoundOk = riak_kv_util:expand_value(notfound_ok, NFOk0, BucketProps),
DeletedVClock = get_option(deletedvclock, Options, false),
GetCore = riak_kv_get_core:init(N, R, FailThreshold,
NotFoundOk, AllowMult,
DeletedVClock),
{next_state, execute, StateData#state{get_core = GetCore,
timeout = Timeout,
req_id = ReqId}, 0}
end.
%% @private
execute(timeout, StateData0=#state{timeout=Timeout,req_id=ReqId,
bkey=BKey,
preflist2 = Preflist2}) ->
TRef = schedule_timeout(Timeout),
Preflist = [IndexNode || {IndexNode, _Type} <- Preflist2],
riak_kv_vnode:get(Preflist, BKey, ReqId),
StateData = StateData0#state{tref=TRef},
{next_state,waiting_vnode_r,StateData}.
%% @private
waiting_vnode_r({r, VnodeResult, Idx, _ReqId}, StateData = #state{get_core = GetCore}) ->
UpdGetCore = riak_kv_get_core:add_result(Idx, VnodeResult, GetCore),
case riak_kv_get_core:enough(UpdGetCore) of
true ->
{Reply, UpdGetCore2} = riak_kv_get_core:response(UpdGetCore),
NewStateData2 = update_timing(StateData#state{get_core = UpdGetCore2}),
client_reply(Reply, NewStateData2),
update_stats(Reply, NewStateData2),
maybe_finalize(NewStateData2);
false ->
{next_state, waiting_vnode_r, StateData#state{get_core = UpdGetCore}}
end;
waiting_vnode_r(request_timeout, StateData) ->
S2 = update_timing(StateData),
update_stats(timeout, S2),
client_reply({error,timeout}, S2),
finalize(S2).
%% @private
waiting_read_repair({r, VnodeResult, Idx, _ReqId},
StateData = #state{get_core = GetCore}) ->
UpdGetCore = riak_kv_get_core:add_result(Idx, VnodeResult, GetCore),
maybe_finalize(StateData#state{get_core = UpdGetCore});
waiting_read_repair(request_timeout, StateData) ->
finalize(StateData).
%% @private
handle_event(_Event, _StateName, StateData) ->
{stop,badmsg,StateData}.
%% @private
handle_sync_event(_Event, _From, _StateName, StateData) ->
{stop,badmsg,StateData}.
%% @private
handle_info(request_timeout, StateName, StateData) ->
?MODULE:StateName(request_timeout, StateData);
%% @private
handle_info(_Info, _StateName, StateData) ->
{stop,badmsg,StateData}.
%% @private
terminate(Reason, _StateName, _State) ->
Reason.
%% @private
code_change(_OldVsn, StateName, State, _Extra) -> {ok, StateName, State}.
%% ====================================================================
%% Internal functions
%% ====================================================================
maybe_finalize(StateData=#state{get_core = GetCore}) ->
case riak_kv_get_core:has_all_results(GetCore) of
true -> finalize(StateData);
false -> {next_state,waiting_read_repair,StateData}
end.
finalize(StateData=#state{get_core = GetCore}) ->
{Action, UpdGetCore} = riak_kv_get_core:final_action(GetCore),
UpdStateData = StateData#state{get_core = UpdGetCore},
case Action of
delete ->
maybe_delete(UpdStateData);
{read_repair, Indices, RepairObj} ->
read_repair(Indices, RepairObj, UpdStateData);
_Nop ->
ok
end,
{stop,normal,StateData}.
%% Maybe issue deletes if all primary nodes are available.
%% Get core will only requestion deletion if all vnodes
%% replies with the same value.
maybe_delete(_StateData=#state{n = N, preflist2=Sent,
req_id=ReqId, bkey=BKey}) ->
%% Check sent to a perfect preflist and we can delete
IdealNodes = [{I, Node} || {{I, Node}, primary} <- Sent],
case length(IdealNodes) == N of
true ->
riak_kv_vnode:del(IdealNodes, BKey, ReqId);
_ ->
nop
end.
%% Issue read repairs for any vnodes that are out of date
read_repair(Indices, RepairObj,
#state{req_id = ReqId, starttime = StartTime,
preflist2 = Sent, bkey = BKey, bucket_props = BucketProps}) ->
RepairPreflist = [{Idx, Node} || {{Idx, Node}, _Type} <- Sent,
lists:member(Idx, Indices)],
riak_kv_vnode:readrepair(RepairPreflist, BKey, RepairObj, ReqId,
StartTime, [{returnbody, false},
{bucket_props, BucketProps}]),
folsom_metrics:notify({read_repairs, 1}).
get_option(Name, Options, Default) ->
proplists:get_value(Name, Options, Default).
schedule_timeout(infinity) ->
undefined;
schedule_timeout(Timeout) ->
erlang:send_after(Timeout, self(), request_timeout).
client_reply(Reply, StateData = #state{from = {raw, ReqId, Pid}, options = Options}) ->
Msg = case proplists:get_value(details, Options, false) of
false ->
{ReqId, Reply};
[] ->
{ReqId, Reply};
Details ->
{OkError, ObjReason} = Reply,
Info = client_info(Details, StateData, []),
{ReqId, {OkError, ObjReason, Info}}
end,
Pid ! Msg.
update_timing(StateData = #state{startnow = StartNow}) ->
EndNow = now(),
StateData#state{get_usecs = timer:now_diff(EndNow, StartNow)}.
update_stats({ok, Obj}, #state{get_usecs = GetUsecs}) ->
%% Get the number of siblings and the object size. For object
%% size, get an approximation by adding together the bucket, key,
%% vectorclock, and all of the siblings. This is more complex than
%% calling term_to_binary/1, but it should be easier on memory,
%% especially for objects with large values.
NumSiblings = riak_object:value_count(Obj),
Contents = riak_object:get_contents(Obj),
ObjSize =
size(riak_object:bucket(Obj)) +
size(riak_object:key(Obj)) +
size(term_to_binary(riak_object:vclock(Obj))) +
lists:sum([size(term_to_binary(MD)) + value_size(Value) || {MD, Value} <- Contents]),
folsom_metrics:notify({node_gets_total, {inc, 1}}),
folsom_metrics:notify({get_fsm_time, GetUsecs}),
folsom_metrics:notify({node_get_fsm_siblings, NumSiblings}),
folsom_metrics:notify({node_get_fsm_objsize, ObjSize});
update_stats(_, #state{get_usecs = GetUsecs}) ->
folsom_metrics:notify({node_gets_total, {inc, 1}}),
folsom_metrics:notify({get_fsm_time, GetUsecs}).
value_size(Value) when is_binary(Value) -> size(Value);
value_size(Value) -> size(term_to_binary(Value)).
client_info(true, StateData, Acc) ->
client_info(details(), StateData, Acc);
client_info([], _StateData, Acc) ->
Acc;
client_info([timing | Rest], StateData = #state{get_usecs = GetUsecs}, Acc) ->
client_info(Rest, StateData, [{duration, GetUsecs} | Acc]);
client_info([vnodes | Rest], StateData = #state{get_core = GetCore}, Acc) ->
Info = riak_kv_get_core:info(GetCore),
client_info(Rest, StateData, Info ++ Acc);
client_info([Unknown | Rest], StateData, Acc) ->
client_info(Rest, StateData, [{Unknown, unknown_detail} | Acc]).
details() ->
[timing,
vnodes].
-ifdef(TEST).
-define(expect_msg(Exp,Timeout),
?assertEqual(Exp, receive Exp -> Exp after Timeout -> timeout end)).
%% SLF: Comment these test cases because of OTP app dependency
%% changes: riak_kv_vnode:test_vnode/1 now relies on riak_core to
%% be running ... eventually there's a call to
%% riak_core_ring_manager:get_raw_ring().
-ifdef(BROKEN_EUNIT_PURITY_VIOLATION).
get_fsm_test_() ->
{spawn, [{ setup,
fun setup/0,
fun cleanup/1,
[
fun happy_path_case/0,
fun n_val_violation_case/0
]
}]}.
setup() ->
%% Set infinity timeout for the vnode inactivity timer so it does not
%% try to handoff.
application:load(riak_core),
application:set_env(riak_core, vnode_inactivity_timeout, infinity),
application:load(riak_kv),
application:set_env(riak_kv, storage_backend, riak_kv_memory_backend),
application:set_env(riak_core, default_bucket_props, [{r, quorum},
{w, quorum}, {pr, 0}, {pw, 0}, {rw, quorum}, {n_val, 3},
{basic_quorum, true}, {notfound_ok, false}]),
%% Have tracer on hand to grab any traces we want
riak_core_tracer:start_link(),
riak_core_tracer:reset(),
riak_core_tracer:filter([{riak_kv_vnode, readrepair}],
fun({trace, _Pid, call,
{riak_kv_vnode, readrepair,
[Preflist, _BKey, Obj, ReqId, _StartTime, _Options]}}) ->
[{rr, Preflist, Obj, ReqId}]
end),
ok.
cleanup(_) ->
dbg:stop_clear().
happy_path_case() ->
riak_core_tracer:collect(5000),
%% Start 3 vnodes
Indices = [1, 2, 3],
Preflist2 = [begin
{ok, Pid} = riak_kv_vnode:test_vnode(Idx),
{{Idx, Pid}, primary}
end || Idx <- Indices],
Preflist = [IdxPid || {IdxPid,_Type} <- Preflist2],
%% Decide on some parameters
Bucket = <<"mybucket">>,
Key = <<"mykey">>,
Nval = 3,
BucketProps = bucket_props(Bucket, Nval),
%% Start the FSM to issue a get and check notfound
ReqId1 = 112381838, % erlang:phash2(erlang:now()).
R = 2,
Timeout = 1000,
{ok, _FsmPid1} = test_link(ReqId1, Bucket, Key, R, Timeout, self(),
[{starttime, 63465712389},
{n, Nval},
{bucket_props, BucketProps},
{preflist2, Preflist2}]),
?assertEqual({error, notfound}, wait_for_reqid(ReqId1, Timeout + 1000)),
%% Update the first two vnodes with a value
ReqId2 = 49906465,
Value = <<"value">>,
Obj1 = riak_object:new(Bucket, Key, Value),
riak_kv_vnode:put(lists:sublist(Preflist, 2), {Bucket, Key}, Obj1, ReqId2,
63465715958, [{bucket_props, BucketProps}], {raw, ReqId2, self()}),
?expect_msg({ReqId2, {w, 1, ReqId2}}, Timeout + 1000),
?expect_msg({ReqId2, {w, 2, ReqId2}}, Timeout + 1000),
?expect_msg({ReqId2, {dw, 1, ReqId2}}, Timeout + 1000),
?expect_msg({ReqId2, {dw, 2, ReqId2}}, Timeout + 1000),
%% Issue a get, check value returned.
ReqId3 = 30031523,
{ok, _FsmPid2} = test_link(ReqId3, Bucket, Key, R, Timeout, self(),
[{starttime, 63465712389},
{n, Nval},
{bucket_props, BucketProps},
{preflist2, Preflist2}]),
?assertEqual({ok, Obj1}, wait_for_reqid(ReqId3, Timeout + 1000)),
%% Check readrepair issued to third node
ExpRRPrefList = lists:sublist(Preflist, 3, 1),
riak_kv_test_util:wait_for_pid(_FsmPid2),
riak_core_tracer:stop_collect(),
?assertEqual([{0, {rr, ExpRRPrefList, Obj1, ReqId3}}],
riak_core_tracer:results()).
n_val_violation_case() ->
ReqId1 = 13210434, % erlang:phash2(erlang:now()).
Bucket = <<"mybucket">>,
Key = <<"badnvalkey">>,
Nval = 3,
R = 5,
Timeout = 1000,
BucketProps = bucket_props(Bucket, Nval),
%% Fake three nodes
Indices = [1, 2, 3],
Preflist2 = [begin
{{Idx, self()}, primary}
end || Idx <- Indices],
{ok, _FsmPid1} = test_link(ReqId1, Bucket, Key, R, Timeout, self(),
[{starttime, 63465712389},
{n, Nval},
{bucket_props, BucketProps},
{preflist2, Preflist2}]),
?assertEqual({error, {n_val_violation, 3}}, wait_for_reqid(ReqId1, Timeout + 1000)).
wait_for_reqid(ReqId, Timeout) ->
receive
{ReqId, Msg} -> Msg
after Timeout ->
{error, req_timeout}
end.
bucket_props(Bucket, Nval) -> % riak_core_bucket:get_bucket(Bucket).
[{name, Bucket},
{allow_mult,false},
{big_vclock,50},
{chash_keyfun,{riak_core_util,chash_std_keyfun}},
{dw,quorum},
{last_write_wins,false},
{linkfun,{modfun,riak_kv_wm_link_walker,mapreduce_linkfun}},
{n_val,Nval},
{old_vclock,86400},
{postcommit,[]},
{precommit,[]},
{r,quorum},
{rw,quorum},
{small_vclock,50},
{w,quorum},
{young_vclock,20}].
-endif. % BROKEN_EUNIT_PURITY_VIOLATION
-endif.