Skip to content

Commit

Permalink
Update code comments based on Doug's review
Browse files Browse the repository at this point in the history
  • Loading branch information
nickelization committed Mar 15, 2016
1 parent ee5c874 commit 7058ad7
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/riak_kv_entropy_info.erl
Expand Up @@ -174,12 +174,10 @@ update_index_info_impl(Key, Cmd) ->
%% contention if lots of different pieces of code are all relying on
%% it at once.
%%
%% If we do ever want to remove the call to global:trans and replace
%% it with something better, I think we could come up with some code
%% to allow concurrent updates by writing multiple versions of the
%% record to ETS, and then we could detect that on read and resolve
%% the conflict based on how we want the stats to be calculated. This
%% would be trickier to implement, but should yield great performance.
%% If we find that the call to global:trans is a bottleneck, we can
%% explore other options (probably either synchronizing updates through
%% a pool of workers, or maybe some sort of CRDT-style conflict
%% resolution mechanism).
Info = case ets:lookup(?ETS, {index, Key}) of
[] ->
#index_info{};
Expand Down

5 comments on commit 7058ad7

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from JeetKunDoug
at 7058ad7

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/riak_kv/nem/transaction-for-update_index_info = 7058ad7 into borshop-integration-1370-nem/transaction-for-update_index_info

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/riak_kv/nem/transaction-for-update_index_info = 7058ad7 merged ok, testing candidate = e3938a4

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding 2.0 to borshop-integration-1370-nem/transaction-for-update_index_info = e3938a4

Please sign in to comment.