Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Luke usage #433

Merged
merged 2 commits into from
Nov 14, 2012
Merged

Remove Luke usage #433

merged 2 commits into from
Nov 14, 2012

Conversation

beerriot
Copy link

riak_pipe powers MapReduce queries now

riak_pipe powers MapReduce queries now
@beerriot
Copy link
Author

In reviewing other PRs, I was reminded that we can also remove the "mget" call from riak_kv_vnode. Luke-based MapReduce was the only thing that used it.

@ghost ghost assigned slfritchie and beerriot Nov 13, 2012
@slfritchie
Copy link
Contributor

Bryan, if you'd create a new issue to remove the mget call, I'm fine with that.

No new failing EUnit failures, no significant changes to Dialyzer warnings. +1 to merge all 5 related PRs, many thanks!

@seancribbs
Copy link
Contributor

finksplosion

@kellymclaughlin
Copy link
Contributor

Can this be removed as part of this pr also?

Nodes without Luke are unable to provide 'legacy' MapReduce. They can
only provide 'pipe' MapReduce.
@beerriot
Copy link
Author

Good catch, @kellymclaughlin! Unfortunately, it can't be remove the {riak_kv, mapred_system} capability just yet. If we remove it, and then there is a cluster membership change before all nodes are running the version of Riak with it removed, a renegotiation will flip those old nodes back to legacy, which will then cause them to fail at MapReduce queries.

However, new nodes also shouldn't lie about what they're capable of. I've just pushed a patch to remove legacy from what new nodes announce. Eventually we'll get all nodes announcing pipe by default, and then we can remove it.

@kellymclaughlin
Copy link
Contributor

Great point, I need to do that for my legacy keylisting pr as well.

@kellymclaughlin
Copy link
Contributor

+1 to merge after last commit

beerriot added a commit that referenced this pull request Nov 14, 2012
@beerriot beerriot merged commit cb88551 into master Nov 14, 2012
beerriot added a commit that referenced this pull request Nov 14, 2012
As of #433 (removal of luke), nothing uses this command.
beerriot added a commit that referenced this pull request Nov 15, 2012
It was removed when luke was removed in PR #433.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants