Implement key count estimation via AAE trees #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates riak_kv_index_hashtree to provide an API around the new AAE-based key count estimation feature added to the hashtree module in riak_core. This provides a mechanism to estimate the number of keys in a given K/V vnode based on its AAE trees. This estimate is used to enable an improvement in the operation of AAE-based fullsync replication in Riak Enterprise. Authored-by: Mikael Lixenstrand <mikael.lixenstrand@erlang-solutions.com> Rebased-by: Joseph Blomstedt <joe@basho.com>
This commit changes riak_kv_index_hashtree to return not_responsible when provided an illegal IndexN in estimate_keys/2. Prior to this commit, an invalid IndexN would cause the hashtree process to crash. Authored-by: Kresten Krab Thorup <krab@trifork.com> Rebased-by: Joseph Blomstedt <joe@basho.com>
This was referenced Oct 7, 2014
|
👍 5b47019 |
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
Dec 19, 2014
Implement key count estimation via AAE trees Reviewed-by: engelsanchez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request updates
riak_kv_index_hashtreeto provide an API around the new AAE-based key count estimation feature added to thehashtreemodule inriak_core.This provides a mechanism to estimate the number of keys in a given K/V vnode based on its AAE trees.
This estimate is used to enable an improvement in the operation of AAE-based fullsync replication in Riak Enterprise.
Sibling pull-requests: basho/riak_core#633, basho/riak_repl#623