Add extra details to vnodeid warning for KV679 [JIRA: RIAK-2375]

[russelldb]

And downgrade the level to warn from error since the per-key-epoch code
stops this from being an error, merely a warning that something is
rotten in Denmark

[jonmeredith]

Reviewing - was just looking for tests.

Should https://github.com/basho/riak_test/commits/bug/rdb/gh679 have been merged as part of KV679 work, or was it just a demonstration?

[jonmeredith]

Confirmed log message with some local trickery fudging an object.

(riak@127.0.0.1)10> O2.                                                   
{r_object,<<"b">>,<<"k">>,
          [{r_content,{dict,3,16,16,8,80,48,
                            {[],[],[],[],[],[],[],[],[],[],[],[],[],[],...},
                            {{[],[],[],[],[],[],[],[],[],[],[[...]],[...],...}}},
                      <<"v2">>}],
          [{<<35,9,254,249,47,27,175,47,0,0,117,49>>,{2,63622253829}}],
          {dict,1,16,16,8,80,48,
                {[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],...},
                {{[],[],[],[],[],[],[],[],[],[],[],[],[],...}}},
          <<"v3">>}
(riak@127.0.0.1)11> riak_object:vclock(O2).
[{<<35,9,254,249,47,27,175,47,0,0,117,49>>,{2,63622253829}}]
(riak@127.0.0.1)12> O3 = riak_object:set_vclock(O2, [{<<35,9,254,249,47,27,175,47,1,0,117,49>>,{1,63622253829}}]).
{r_object,<<"b">>,<<"k">>,
          [{r_content,{dict,3,16,16,8,80,48,
                            {[],[],[],[],[],[],[],[],[],[],[],[],[],[],...},
                            {{[],[],[],[],[],[],[],[],[],[],[[...]],[...],...}}},
                      <<"v2">>}],
          [{<<35,9,254,249,47,27,175,47,1,0,117,49>>,{1,63622253829}}],
          {dict,1,16,16,8,80,48,
                {[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],...},
                {{[],[],[],[],[],[],[],[],[],[],[],[],[],...}}},
          <<"v3">>}
(riak@127.0.0.1)13> C:put(O3).

2016-02-09 09:26:01.354 [warning] <0.967.0>@riak_kv_vnode:maybe_new_key_epoch:2586 Inbound clock entry for <<"#\tþù/\e¯/">> in <<"b">>/<<"k">> greater than local.Epochs: {In:16807217 Local:30001}. Counters: {In:1 Local:4}.

[jonmeredith]

+1 9083bdc

[jonmeredith]

@borshop merge

[jonmeredith]

create jira issue

[cmeiklejohn]

Was that a comment for jira?

[jonmeredith]

Yes - release tracking stuff. Got ideas about it's station and renamed this PR. Silly JIRA.