Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTS-1094] Check table readiness on decode #1545

Merged
merged 1 commit into from Nov 24, 2016

Conversation

paegun
Copy link

@paegun paegun commented Nov 23, 2016

Fixes riak-shell crash on attempt to INSERT INTO a table that does not exist (is not active).

  • exposed get_table_status for use in query validation path.
  • added check for table readiness (active, sufficient version) for query execution.
    • the check excludes query types that do not have a table, ie SHOW TABLES.

Was originally developed as #1530 , but due to several factors this counter proposal for solution was offered (factors follow):

  • long duration before the PR was reviewed, much underlying changed, chasing dialyzer errors, test failures due to missed pattern matches due to changes to function returns, ... pragmatism called for rethinking a rewrite of the fix.
  • DRY, there should be one way to determine if a table is Active.

…k for table readiness (active, sufficient version) for query execution, excluding query types that do not have a table from such a check.
@gordonguthrie
Copy link

+1 2db8f0f

borshop added a commit that referenced this pull request Nov 24, 2016
[RTS-1094] Check table readiness on decode

Reviewed-by: gordonguthrie
@gordonguthrie gordonguthrie merged commit 50d4035 into riak_ts-develop Nov 24, 2016
@paegun paegun deleted the jbg-pre-sql-check-table-exists branch November 25, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants