qry_buffers: generate small file names for temp tables #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent "file name too long" errors
|
Thanks @hmmr! Settings---
minimum_reviewers: 2
merge: true
build_steps:
- make clean
- make deps
- make compile
- make test
- make xref
- make dialyzer
org_mode: true
timeout: 1800 |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
|
👍 |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
|
@hmmr Where does the binary come from which generates the |
|
It's a simple integer, incremented for each qbuf, printed as a decimal of base 36, giving a short printable string. That string will be unique until the integer overflows, which won't happen within our lifetime. And, we don't need to care about stomping over any buffers if the query buffer manager crashes -- any leftovers will be discarded anyway. Of course |
|
Only failures were: 👍 |
|
+1 |
|
thumbot retry |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
|
+1 |
1 similar comment
|
+1 |
|
Merging and closing this pr |
|
Successfully merged basho/riak_kv/pulls/1626 (173a783 on to riak_ts-develop-1.5) ---
:sha: d00471f5586348dd7c08c14c12bda0df51b3a7f7
:merged: true
:message: Pull Request successfully merged
|
hmmr
added a commit
that referenced
this pull request
Mar 8, 2017
* qry_buffers: generate small file names for temp tables to prevent "file name too long" errors * qry_buffers: use make_ref instead of faking now/0 * qry_buffers: demystify make_qbuf_id # Conflicts: # src/riak_kv_qry_buffers.erl
thumbot
pushed a commit
that referenced
this pull request
Mar 9, 2017
* qry_buffers: generate small file names for temp tables (#1626) * qry_buffers: generate small file names for temp tables to prevent "file name too long" errors * qry_buffers: use make_ref instead of faking now/0 * qry_buffers: demystify make_qbuf_id # Conflicts: # src/riak_kv_qry_buffers.erl
hmmr
added a commit
to TI-Tokyo/riak_kv
that referenced
this pull request
Jan 13, 2022
* qry_buffers: generate small file names for temp tables to prevent "file name too long" errors * qry_buffers: use make_ref instead of faking now/0 * qry_buffers: demystify make_qbuf_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTS-1760 (#1625), #1625.
Avoid creating temp table names by stringing field names, which is gratuitously stupid.
Note that 1.6 is going to have #1601 whereby this issue autocloses in mainline.