Fix stats for r15b02 #415
Merged
Fix stats for r15b02 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTP team removed the erlang:system_info(global_heap_size) stat and so riak-admin status and riak stats fail hard. This commit wraps the call to said stat in a try catch. On < 15b02 you get global heapsize. Otherwise you get the atom 'deprecated'.
|
/stats - https://gist.github.com/29b7a1dcf831ac816104 |
russelldb
pushed a commit
that referenced
this pull request
Nov 25, 2012
The bulk of the riak_kv_stat code was moved to a to-be deprecated module riak_kv_stat_bc. The change that fixes memory stats for erlang r15b02 was lost. See riak_kv PR #415 for details.
buddhisthead
added a commit
that referenced
this pull request
Nov 26, 2012
Re-instate code from #415 that was lost in later changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTP team removed the erlang:system_info(global_heap_size) stat
and so riak-admin status and riak stats fail hard.
This commit wraps the call to said stat in a try catch. On < 15b02
you get global heapsize. Otherwise you get the atom 'deprecated'.
Addresses #411