Fix handling of bucket+type with MR keyfilters #888
Conversation
|
ping @broach, what happened with the MR tests that were failing? Did you have a chance to test this fix against them? |
|
Re-ping @broach. What happened with this? Were you able to verify that this fixed the Java client tests? |
Roach found this while writing tests for the Java client. If using the JS syntax for using bucket types and keyfilters together through the PB interface, this was broken. In the http case without security, the path is not touched so it didn't show before.
|
This fix can be verified by basho/riak_test#623. A new commit was added to fix another problem for bucket types + keyfilters in the parsing stage |
Fix handling of bucket+type with MR keyfilters Reviewed-by: kellymclaughlin
|
@borshop merge |
|
@engelsanchez Yeah, sorry - I had this open in a tab as a nagging reminder that I hadn't gotten to it and it hadn't updated. Thanks. |
|
Actually @broach, it would be a good idea to make sure that your Java client tests do pass after the fix to make sure it's the exact code path you were hitting. Let me know if anything doesn't work and we can open a new issue. |
|
@engelsanchez Finally got here. The test now passes. 👍 |
Roach found this while writing tests for the Java client. If using the
JS syntax for using bucket types and keyfilters together through the PB
interface, this was broken. In the http case without security, the path
is not touched so it didn't show before.
/cc @broach can you verify with the tests you are building?