Add syntax version to .proto files #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @shaneutt! Settings---
minimum_reviewers: 2
merge: true
build_steps:
- make clean
- make deps
- make compile
- make test
- make xref
- make dialyzer
org_mode: true
timeout: 1800 |
There seems to be an issue with build step **make_compile,make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
⛔ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
|
The addition of |
alexmoore
reviewed
Jan 5, 2017
| @@ -13,6 +13,8 @@ | |||
| * git add -A; git commit -m 'Update erlang code from .proto files' | |||
| */ | |||
|
|
|||
| syntax = "proto2"; | |||
There was a problem hiding this comment.
This syntax modifier is only valid in the Protocol Buffers 3 spec IIRC: https://developers.google.com/protocol-buffers/docs/proto3#simple
| @@ -4145,6 +4145,7 @@ verify_msg(Msg, Opts) -> | |||
| end. | |||
|
|
|||
|
|
|||
| -dialyzer({nowarn_function,v_msg_mapfield/3}). | |||
There was a problem hiding this comment.
These will have to go in the dialyzer.ignore-warnings file I think, probably a syntax that was added in R16 or R17.
There was a problem hiding this comment.
It's a compilation issue. If you run protogen using a "too new" Erlang, gpb will insert these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocclients using libprotoc 3.0.0+ want.protofiles to specify their protocol buffers syntax version.This adds the syntax version to avoid warnings from libprotoc 3.0.0+.