New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pretty_pr_with_unicode_test/0 #70
Conversation
Thanks @javajolt! Settings---
minimum_reviewers: 2
build_steps:
- make clean
- make deps
- make compile
- make test
- make xref
- make dialyzer
merge: true
org_mode: true
timeout: 1790 |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
That is correct value - I refactored it and dropped the ball... |
+1 |
1 similar comment
+1 |
✅ 2 of 2 Code reviews from organization basho
|
Merging and closing this pr |
Successfully merged basho/riak_shell/pulls/70 (a9d1436 on to develop) ---
:sha: 1015df1758ace7df8b32ed358975b34fafe46046
:merged: true
:message: Pull Request successfully merged
|
+1 |
This is the actual result produced by this command.
However, is this the expected result @gordonguthrie?