Remove admin.secret from configuration #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuenishi
force-pushed
the
ku/remove-admin-secret
branch
from
12f8708
to
9369606
Compare
Instead it is retrieved from Riak directly in startup sequence, from admin.key specified at configuration file. But in special case admin.key is specified as "admin-key", it does not retrieve admin secret from Riak, instead sets it as admin-secret. admin.secret will be deprecated in near future, which is currently ignored at all.
| _ -> | ||
| ok | ||
| end, | ||
| StrongOpts = [{r, all}, {pr, one}, {notfound_ok, false}], |
There was a problem hiding this comment.
When one of nodes which are responsible the admin user object, Stanchion will fail to start because the fallback vnode does not have it and responds notfound. Is quorum sufficient for R?
|
All riak_test passed. I will 👍 after the above comment is addressed. |
|
Updated ^^; |
shino
added a commit
that referenced
this pull request
Dec 15, 2015
Remove admin.secret from configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead it is retrieved from Riak directly in startup sequence, from
admin.key specified at configuration file. But in special case
admin.key is specified as "admin-key", it does not retrieve admin
secret from Riak, instead sets it as admin-secret. admin.secret will
be deprecated in near future, which is currently ignored at all.