Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add check for 0 covariance in studentization #322

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

bashtage
Copy link
Owner

@bashtage bashtage commented Nov 5, 2019

Ensure covariance is positive and meaningfully large

@pep8speaks
Copy link

pep8speaks commented Nov 5, 2019

Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-05 15:12:56 UTC

Ensure covariance is positive and meaningfully large
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 99.597% when pulling 61f7d47 on studentization-error into 6434d57 on master.

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #322 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   99.41%   99.41%   +<.01%     
==========================================
  Files          46       46              
  Lines       10493    10508      +15     
  Branches      907      908       +1     
==========================================
+ Hits        10432    10447      +15     
  Misses         18       18              
  Partials       43       43
Impacted Files Coverage Δ
arch/tests/bootstrap/test_bootstrap.py 100% <100%> (ø) ⬆️
arch/utility/exceptions.py 100% <100%> (ø) ⬆️
arch/bootstrap/base.py 96.66% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6434d57...61f7d47. Read the comment docs.

@bashtage bashtage merged commit 2609f34 into master Nov 5, 2019
@bashtage bashtage deleted the studentization-error branch November 5, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants