Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add callable rng for simulation forecasts #227

Merged
merged 1 commit into from Sep 27, 2018
Merged

Conversation

bashtage
Copy link
Owner

Add callable rng for simulation forecasts so that users can
provide a different rng than the one used in the model.

closes #225

@coveralls
Copy link

coveralls commented Sep 25, 2018

Coverage Status

Coverage increased (+0.8%) to 98.986% when pulling 353f89f on add-rng-forecast into 475ef9a on master.

@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #227 into master will decrease coverage by 0.8%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   98.19%   97.38%   -0.81%     
==========================================
  Files          30       30              
  Lines        8730     8750      +20     
  Branches      780      751      -29     
==========================================
- Hits         8572     8521      -51     
- Misses         85      156      +71     
  Partials       73       73
Impacted Files Coverage Δ
arch/univariate/base.py 85.99% <100%> (-10.11%) ⬇️
arch/univariate/mean.py 93.63% <100%> (+0.01%) ⬆️
arch/tests/univariate/test_variance_forecasting.py 99.65% <100%> (ø) ⬆️
arch/tests/univariate/test_mean.py 97.45% <0%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475ef9a...353f89f. Read the comment docs.

Add callable rng for simulation forecasts so that users can
provide a different rng than the one used in the model.

closes #225
@bashtage bashtage merged commit 95ea86f into master Sep 27, 2018
@bashtage bashtage deleted the add-rng-forecast branch September 27, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom scenarios to the forecast method
2 participants