Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Pass extra_kwarg into bca calculations #367

Merged
merged 1 commit into from Apr 11, 2020
Merged

BUG: Pass extra_kwarg into bca calculations #367

merged 1 commit into from Apr 11, 2020

Conversation

bashtage
Copy link
Owner

extra_kwargs was not being passed into the bca acceleration function

closes #366

extra_kwargs was not being passed into the bca acceleration function

closes #366
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #367 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   99.33%   99.34%           
=======================================
  Files          66       66           
  Lines       13021    13031   +10     
  Branches     1105     1106    +1     
=======================================
+ Hits        12935    12945   +10     
  Misses         31       31           
  Partials       55       55           
Impacted Files Coverage Δ
arch/bootstrap/base.py 96.47% <100.00%> (+0.01%) ⬆️
arch/tests/bootstrap/test_bootstrap.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71a2fb...daf1969. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 11, 2020

Coverage Status

Coverage increased (+0.0003%) to 99.631% when pulling daf1969 on bca-fix into e71a2fb on master.

@bashtage bashtage merged commit 8129d98 into master Apr 11, 2020
@bashtage bashtage deleted the bca-fix branch April 11, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method 'bca' fails confidence interval when passing extra_kwargs
2 participants